-
-
Notifications
You must be signed in to change notification settings - Fork 79
Resolve case-sensitivity at prepare time #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
344b177 to
62b41a2
Compare
c4d1b16 to
2fb76b0
Compare
domenic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't quite do what I suggested. It looks up the case-sensitivity of the property every time the setter is called, which is not necessary. Instead the case-sensitivity should be looked up at prepare-time, so that when we generate lib/generated/propertyDescriptors.js, the calls look like createGenericPropertyDescriptor("animation-name", { caseSensitive: true }).
|
Looking back at the PR, I wondered if it would be better to combine generatePropertyDefinitions.mjs and generatePropertyDescriptors.mjs into a single file. |
domenic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking back at the PR, I wondered if it would be better to combine generatePropertyDefinitions.mjs and generatePropertyDescriptors.mjs into a single file.
WDYT?
I think this is a good idea. It is very related to the discussion at #304 (comment).
But, let me merge this first as it is a good improvement by itself.
Another approach to fix #303
Closes #304