Hotfix of remove method #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rare bug could happen when removing and linking element back to tree in index method. Index method was returning cached value instead of recomputing the index if the element had previously same cachedIndexVersion as new parent had childrenVersion. In this fix we are purging cachedIndexVersion in remove method as removed elements dont belong to any children collection anyway.
Member
|
Thanks a lot for finding this. Could you perhaps add a unit test that fails if the the bug is present, |
Contributor
Author
|
Unit test added. |
Member
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rare bug could happen when removing and linking element back to tree in index method. Index method was returning cached value instead of recomputing the index if the element had previously same cachedIndexVersion as new parent had childrenVersion. In this fix we are purging cachedIndexVersion in remove method as removed elements dont belong to any children collection anyway.