Skip to content

Conversation

@dmail
Copy link
Member

@dmail dmail commented Dec 8, 2021

Fixes #48

Explicit entry points (3.0.0)

  • Replace checkImportResolution with entryPointsToCheck
  • No more entry point deduction by parsing package.json
  • Better documentation for import resolution warnings and auto mapping
  • More consistency in documentation

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Performance impact

Impact on 9 metrics when merging many_entry_points into master. Before drawing conclusion, keep in mind performance variability.

package metrics (-1.43%)
Metric Before merge After merge Impact
import duration 0.33 seconds 0.325 seconds -0.005 seconds / -1.52% ↘️
import memory heap used 6.66 MB 6.66 MB -9.54 KB / -0.14% ↘️
npm tarball size 83.55 KB 82.92 KB -650 B / -0.76% ↘️
npm tarball unpacked size 370.86 KB 367.65 KB -3.21 KB / -0.87% ↘️
npm tarball file count 26 25 -1 / -3.85% ↘️
write importmap metrics (+0.1%)
Metric Before merge After merge Impact
write importmap duration 0.338 seconds 0.34 seconds +0.002 seconds / +0.59% ↗️
write importmap memory heap used 6.75 MB 6.73 MB -19.86 KB / -0.29% ↘️
number of fs read operation 0 0 👻
number of fs write operation 8 8 👻
Generated by @jsenv/performance-impact during performance_impact#1553599488 on 62bc1c1

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #52 (62bc1c1) into master (ef2ada2) will decrease coverage by 0.21%.
The diff coverage is 72.72%.

@dmail dmail merged commit 0888091 into master Dec 8, 2021
@dmail dmail deleted the many_entry_points branch December 8, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use param to get entry point file

2 participants