Skip to content

Publish updater feeds before APT validation#169

Merged
jsgrrchg merged 2 commits into
mainfrom
fix/release-feed-publish-order
May 29, 2026
Merged

Publish updater feeds before APT validation#169
jsgrrchg merged 2 commits into
mainfrom
fix/release-feed-publish-order

Conversation

@jsgrrchg
Copy link
Copy Markdown
Owner

Summary

  • Publish Electron updater feeds to gh-pages immediately after staging them.
  • Keep APT repository generation, validation, and publication as a separate later publish step.
  • Move feed URL printing next to the updater feed publish step so release logs show the desktop update endpoints even if APT fails later.

Root cause

The v0.3.1 release built and uploaded GitHub Release assets successfully, but the Pages publish job failed during the APT validation step. Because updater feeds and APT metadata were committed together at the end, the public Electron feeds stayed on v0.3.0 even though v0.3.1 assets existed.

Impact

Future APT validation failures can still fail the release workflow, but they will no longer block desktop update discovery once the updater feeds have been generated.

Validation

  • node scripts/validate-release-metadata.mjs --tag v0.3.1
  • node --test scripts/apt-repo.test.mjs
  • Parsed .github/workflows/release-desktop.yml with the YAML parser from the desktop dependencies

@jsgrrchg jsgrrchg marked this pull request as ready for review May 29, 2026 09:41
@jsgrrchg jsgrrchg merged commit 400a9fb into main May 29, 2026
12 checks passed
@jsgrrchg jsgrrchg deleted the fix/release-feed-publish-order branch May 30, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant