Clean up review diff accumulation flow#4
Merged
Merged
Conversation
jsgrrchg
added a commit
that referenced
this pull request
Apr 5, 2026
spamsch
pushed a commit
to spamsch/NeverWrite
that referenced
this pull request
May 20, 2026
De-duplicate descriptor (jsgrrchg#2): Extract CLAUDE_TERMINAL_DESCRIPTOR and buildClaudeTerminalSetupStatus into features/ai/utils/claudeTerminalRuntime.ts. chatStore and AIProvidersSettings now share one definition with consistent copy. Subscribe-based terminal ready (jsgrrchg#3): Replace setInterval+setTimeout polling in waitForTerminalRunning with a synchronous pre-check followed by useTerminalRuntimeStore.subscribe. No busy loop, no 100ms lag, logs a warning on timeout. Raise settle delay (jsgrrchg#4): CLAUDE_TUI_SETTLE_MS 2000 → 3500 with a comment explaining the limitation and what a proper fix would require. Binary check cache (#1): Module-level cache in checkClaudeCodeInstalled() so chatStore, TerminalSettings, and AIProvidersSettings share one sh spawn rather than three. Persist auto-selection (jsgrrchg#5): When Claude Code is auto-selected on first launch (binary found, no prior preference), persist it to AiPreferences so binary removal/reinstall doesn't silently change the default on next start. ACP runtime auto-selection is NOT persisted — only the Claude Code terminal selection is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes the dead local hunk-accumulation path from the review UI and store.
Why
The canonical review semantics already live in the ActionLog. The old accumulation path duplicated resolution behavior and risked semantic drift.
This change keeps a single canonical resolution path while preserving transcript/chat diff rendering for legacy or non-hunk diffs.
Verification
Manual QA:
Tests:
Result: