fix: handle undefined remoteAddress when socket is disconnected#45
Open
Sumit-Mayani wants to merge 1 commit intojshttp:masterfrom
Open
fix: handle undefined remoteAddress when socket is disconnected#45Sumit-Mayani wants to merge 1 commit intojshttp:masterfrom
Sumit-Mayani wants to merge 1 commit intojshttp:masterfrom
Conversation
getSocketAddr returned undefined when req.socket existed but remoteAddress was undefined (disconnected socket). Also hardened the fallback to safely handle missing req.connection. forwarded() now omits the socket address from the result array rather than including undefined. Closes jshttp#12 Assisted-by AI: Claude (Anthropic)
Sumit-Mayani
force-pushed
the
fix/disconnected-socket-undefined
branch
from
1360c26 to
d9cb0de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12
Problem
getSocketAddrreturnedundefinedin two cases:req.socketexists butremoteAddressisundefined(socket was disconnected)req.socketis falsy andreq.connectionis also absent — accessing.remoteAddressonundefinedthrowsThe
undefinedthen leaked into theaddrsarray returned byforwarded().Fix
getSocketAddr: safely readremoteAddressfrom whichever ofreq.socket/req.connectionis present; returnundefinedif neither has an addressforwarded(): skip the socket address when it isundefinedrather than including it in the resultTesting
Added two new tests for the disconnected-socket cases. All 11 tests pass.