Improve number parsing #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeembrey
commented
Jan 21, 2026
| } | ||
|
|
||
| var startStr = arr[i].slice(0, indexOf).trim() | ||
| var endStr = arr[i].slice(indexOf + 1).trim() |
Member
Author
There was a problem hiding this comment.
I didn't see whitespace in the spec when I quickly browsed, but examples on MDN do use it and parseInt used to work with it too, so I included it for coverage. Otherwise I wouldn't do .trim() here.
bjohansebas
approved these changes
Jan 22, 2026
UlisesGascon
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #57, properly handle a bunch of other edge cases in the parser. E.g.
100x,100.5, multiple dashes, etc. should all be invalid.