Conversation
Un-skip database tests: - NewsModelsTest: 11 skips → 2 (getSite, getSites, getSitesRecent, streamPage, getStreamPageTotal, updateFeed now exercised) - AggroControllerTest: 15 skips → 0 (all controller methods now tested via CLI gate_check bypass) - FrontControllerUnitTest: 7 skips → 0 (about, sites, video endpoints now tested) - YoutubeModelsTest: 7 skips → 4 (getDuration tests now use mocked UtilityModels) New test files: - ValidationServiceTest (26 tests): sanitizeSlug, validateVideoId, validateGateKey, sanitizeInt - SentryLogHandlerTest (17 tests): canHandle, mapLogLevelToSentry, cleanErrorMessage, handle - StorageConfigTest (7 tests): thumbnail paths, cleanup/archive age, default values Improve existing tests: - ThumbnailServiceTest: 13 skips → 0 (private methods tested via reflection + temp files) - FeedControllerTest: 3 skips → 0 (switched to ServiceTestCase for news_feeds table) - AggroHelperTest: safe_file_write invalid path, csrf_action_form, file round-trip tests - ViewHelperTest: 3 skips → 0 (invalid date/timezone exception tests, edge cases) - SecurityFilterTest: 3 new after() method tests for security headers Feature tests: - FrontControllerTest: 8 new feature tests (featured, sites, stream, video, sitemap, robots) Results: 523 tests (+59), 913 assertions (+172), 33 skips (was 86)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Un-skip database tests:
New test files:
Improve existing tests:
Feature tests:
Type of Change
Testing
PR Labels
Additional Notes