Upcoming breaking changes in loo_compare() output#116
Open
florence-bockting wants to merge 4 commits intojsocolar:mainfrom
Open
Upcoming breaking changes in loo_compare() output#116florence-bockting wants to merge 4 commits intojsocolar:mainfrom
loo_compare() output#116florence-bockting wants to merge 4 commits intojsocolar:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the
loopackage, we are making changes to the output structure returned byloo_compare()in PR #300. The main changes are a transition from a matrix to a data frame and the addition of several new columns. Here is an example of the updated output structure:More context on the motivation behind these changes can be found in the updated case study "Uncertainty in Bayesian LOO-CV Model Comparison".
A reverse dependency check revealed that these changes will affect your package. To help smooth the transition, I have already reviewed your code and suggest within this PR changes that should keep your package compatible with both the current and the upcoming
loo_compare()output structure.I may have missed some additional spots in your code that need updating, so please feel free to point those out and I am happy to help. Thank you and please do not hesitate to reach out if you have any questions or concerns.
TODO
flocker_tutorial.Rmdwhere I am uncertain how you want to handle this. In the section "Post-processing > Model comparison" you currently provide the expected output in form of a comment. This expected output will change for the newloo_compare()function.