use service_provider fact to determine init system #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is part one of a set of commits I would like to introduce. I try to keep the changes in logical parts per PR. |
puppetlabs-stdlib provides the fact service_provider since 4.10.0. We can rely on the fact, instead of implementing own logic.
bastelfreak
force-pushed
the
systemdfact
branch
from
cf21d91 to
d433760
Compare
This was referenced Nov 28, 2017
Merged
Contributor
Author
|
@jsok can you review and merge this one? All upcoming changes are based on this. |
jsok
approved these changes
Nov 28, 2017
Owner
jsok
left a comment
jsok
left a comment
There was a problem hiding this comment.
LGTM, maintaining that switch statement is a bit of a nightmare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppetlabs-stdlib provides the fact service_provider since 4.10.0. We
can rely on the fact, instead of implementing own logic.