Bug: crash on 404 when resource ID type does not match query string

[bart-degreed]

Description

See #631 (comment)

Looking at the changes, the trim/split/findindex url parsing feels a bit brittle to me. Wouldn't it be an option to use the route values, like it is done at:

JsonApiDotNetCore/src/JsonApiDotNetCore/Middleware/CurrentRequestMiddleware.cs

Line 251 in d9dd760

private ResourceContext GetCurrentEntity()

?

For example, the debugger shows me for the request path:

api/v3/users/ABC/completions

these route values:

{
  "action": "GetRelationship"
  "controller": "Users"
  "id": "ABC"
  "relationshipName": "completions"
}

Hope this helps.

[bart-degreed]

/cc @wisepotato

[wisepotato]

WOrking on this at the moment, found some weird things. I shouldn't code late at night or early in the morning. I added a relationshipId which should never be set. I'm refactoring the CurrentRequestMiddleware and the adjoining tests to use _routeValues.

Sorry for the inconvenience. Probably a fix incoming either today or monday.

[bart-degreed]

No worries, we all have days like that ;)

[bart-degreed]

@wisepotato I've been working from a detached head since this was introduced. Now that more of my colleagues are going to work on my prototype and I'm hoping to contribute PRs to this repo in the near future, this starts to get inconvenient.

Can you maybe revert this commit until the proper solution is available?

[wisepotato]

I getcha, but will work on this tomorrow.

[maurei]

Got a few things to deliver before the end of the year, but I will prioritise this right after.

[wisepotato]

This is not yet closed.

[maurei]

Whoops, that was unintended

[bart-degreed]

Thanks, my issue is fixed by #651.

As a side effect, it also fixes a bug where the namespace part is missing when rendering URLs in links on getting a list of resources, which I had not noticed earlier.

Example: GET api/v3/articles/

Before:

{
  "meta": {
    "total-records": 3
  },
  "links": {
    "self": "http://localhost/articles"
  },
  "data": [ ... ]
}

After

{
  "meta": {
    "total-records": 3
  },
  "links": {
    "self": "http://localhost/api/v3/articles"
  },
  "data": [ ... ]
}