Skip to content

Fix/fix for string ids #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 23, 2019
Merged

Fix/fix for string ids #651

merged 4 commits into from
Dec 23, 2019

Conversation

@wisepotato
Copy link
Contributor

@wisepotato wisepotato commented Dec 4, 2019 •
edited
Loading

Closes #644.

  • allow for more loosely defined ids, no error checking if they fit that type
  • No type check because this should happen later, as the controllers themselves know the id type.

@wisepotato wisepotato requested a review from maurei December 23, 2019 13:48
@maurei maurei merged commit 585bf84 into master Dec 23, 2019
@wisepotato wisepotato deleted the fix/fix-for-string-ids branch December 23, 2019 13:59
@bart-degreed bart-degreed mentioned this pull request Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maurei maurei maurei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: crash on 404 when resource ID type does not match query string

3 participants

@wisepotato @maurei