Skip to content

chore: follow up on TypeScript ESLint v6 update #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2023
Merged

chore: follow up on TypeScript ESLint v6 update #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
},
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/strict",
"plugin:@typescript-eslint/strict-type-checked",
"plugin:@typescript-eslint/stylistic-type-checked",
"plugin:@angular-eslint/recommended",
"plugin:@angular-eslint/template/process-inline-templates"
],
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions projects/angular-ecmascript-intl/src/lib/relative-time/relative-time.pipe.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ describe('RelativeTimePipe', () => {
testUnit.transform(0);
tick(60000);

// eslint-disable-next-line @typescript-eslint/unbound-method
expect(cdrMock.markForCheck).toHaveBeenCalledTimes(1);

testUnit.ngOnDestroy();
Expand All @@ -221,6 +222,7 @@ describe('RelativeTimePipe', () => {
testUnit.transform(new Date());
tick(600000);

// eslint-disable-next-line @typescript-eslint/unbound-method
expect(cdrMock.markForCheck).toHaveBeenCalledTimes(10);

testUnit.ngOnDestroy();
Expand Down
2 changes: 1 addition & 1 deletion projects/angular-ecmascript-intl/src/lib/relative-time/relative-time.pipe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export class IntlRelativeTimePipe implements PipeTransform, OnDestroy {

const time = new Date(value).getTime();
if (isNaN(time)) {
throw new Error(`${value} is not a valid date`);
throw new Error(`${value.toString()} is not a valid date`);
}

this.#destroy();
Expand Down
4 changes: 3 additions & 1 deletion projects/angular-intl-demo/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@ import { AppModule } from './app/app.module';

platformBrowserDynamic()
.bootstrapModule(AppModule)
.catch((err) => console.error(err));
.catch((err) => {
console.error(err);
});