JSON-e#566
Merged
Merged
Conversation
…ng function names; prevent infinite loop in function parse
Test Results 15 files + 1 15 suites +1 16s ⏱️ ±0s Results for commit b65569f. ± Comparison against base commit e59bd91. This pull request removes 8 and adds 1088 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
3 tasks
Collaborator
Author
|
Going to release as is for now, ignoring the dependency. When that goes through, I'll un-ignore those tests and push an update if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #539
Depends on json-e/json-e#504
There are three tests that involve unicode that I believe are incorrect as they're not properly JSON-escaping the chars. The dependency above is tracking that correction.
Additionally, while I strived to make error messages the same, they're not on about 30 tests. The scenarios still produce errors, as expected, but the message isn't the same. I'm considering this good enough for a first release.