Skip to content

Conversation

@bbrks
Copy link
Contributor

@bbrks bbrks commented Sep 19, 2019

Fixes #405

  • Add test to encode nil map and check for null
  • Fix nil map being encoded as {}

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #406 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   81.81%   81.77%   -0.05%     
==========================================
  Files          41       41              
  Lines        5022     5025       +3     
==========================================
  Hits         4109     4109              
- Misses        792      795       +3     
  Partials      121      121
Impacted Files Coverage Δ
reflect_map.go 87.68% <100%> (+0.18%) ⬆️
reflect_struct_decoder.go 48.74% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27518f6...028e2ef. Read the comment docs.

@taowen taowen merged commit 695ec2b into json-iterator:master Sep 23, 2019
@bbrks bbrks deleted the fix_nil_map_encoding branch November 12, 2019 16:55
zhenzou pushed a commit to zhenzou/jsoniter that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect marshalling of nil map

2 participants