Skip to content

Conversation

@alvarolm
Copy link

@alvarolm alvarolm commented Aug 1, 2020

Required for a custom Unmarshal implementation to check for bytes left after unmarshaling
https://github.com/json-iterator/go/blob/master/config.go#L349

why a custom Unmarshal implementation could be needed ?
since codecs only provide unsafe.Pointer and *Iterator but not the direct value of v that may be needed to avoid reflection cost or just direct handling

thanks !

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #481 into master will not change coverage.
The diff coverage is 98.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #481   +/-   ##
=======================================
  Coverage   86.32%   86.32%           
=======================================
  Files          41       41           
  Lines        5112     5112           
=======================================
  Hits         4413     4413           
  Misses        558      558           
  Partials      141      141           
Impacted Files Coverage Δ
iter_object.go 67.89% <95.23%> (ø)
adapter.go 90.00% <100.00%> (ø)
any.go 80.20% <100.00%> (ø)
config.go 89.36% <100.00%> (ø)
iter.go 90.09% <100.00%> (ø)
iter_array.go 76.59% <100.00%> (ø)
iter_float.go 88.41% <100.00%> (ø)
iter_int.go 90.37% <100.00%> (ø)
iter_skip.go 84.88% <100.00%> (ø)
iter_str.go 90.90% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bce16d...9c92802. Read the comment docs.

@alvarolm
Copy link
Author

alvarolm commented Aug 1, 2020

cc @AllenX2018

@alvarolm
Copy link
Author

alvarolm commented Aug 1, 2020

cc @taowen

@AllenX2018
Copy link
Collaborator

Hi. Can you give an example when you need this function?

@alvarolm alvarolm closed this Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants