Skip to content

Conversation

@javifr
Copy link

@javifr javifr commented May 14, 2015

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.78% when pulling 2a3afef on javifr:jf-activity-from-profile into f08633e on Textalk:development.

@stramel
Copy link
Contributor

stramel commented May 14, 2015

So many additions yet so little description in commit messages. @davidlgj @Dervisevic Should these be squashed into one descriptive commit message?

👍 for creating an Ionic decorator. I assume @davidlgj or @Dervisevic will take a look into it soon. I will take a look this weekend as well.

@javifr
Copy link
Author

javifr commented May 14, 2015

Excuse me guys, I created the pull request by mistake.

Is a repo that i use for ionic decorators, but is far from being mergeable.

Regards!

On Thu, May 14, 2015 at 8:55 PM, Michael Stramel notifications@github.com
wrote:

So many additions yet so little description in commit messages. @davidlgj
https://github.com/davidlgj @Dervisevic https://github.com/Dervisevic
Should these be squashed into one descriptive commit message?

[image: 👍] for creating an Ionic decorator. I assume @davidlgj
https://github.com/davidlgj or @Dervisevic
https://github.com/Dervisevic will take a look into it soon. I will
take a look this weekend as well.


Reply to this email directly or view it on GitHub
#390 (comment)
.

Javi Fernández

@Dervisevic
Copy link
Contributor

Oh, yeah i was wondering about that. It's gonna be exciting to see a new decorator! Should we close this one and you make a new one when it's ready?

@javifr
Copy link
Author

javifr commented May 15, 2015

Sure!

On Fri, May 15, 2015 at 7:33 AM, Denis Dervisevic notifications@github.com
wrote:

Oh, yeah i was wondering about that. It's gonna be exciting to see a new
decorator! Should we close this one and you make a new one when it's ready?


Reply to this email directly or view it on GitHub
#390 (comment)
.

Javi Fernández

@Dervisevic Dervisevic closed this May 15, 2015
@davidlgj
Copy link
Contributor

@javifr what a teaser! ;) Just ping us on gitter if you need any help

@javifr
Copy link
Author

javifr commented May 15, 2015

Glad to hear that! Because I'll need help for sure.

For now it has some patches allowing us to do some things in production, for example this:
captura de pantalla 2015-05-15 a las 10 18 09

I'll try to find time next week and make it a bit cleaner so I can issue a pull request.

Thanks for the interest!

@davidlgj
Copy link
Contributor

Looks awesome!

@Dervisevic
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants