some more ipv6 tests #415
Merged
some more ipv6 tests #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenetheridge
force-pushed
the
ether/more-ipv6-tests
branch
3 times, most recently
from
0366226 to
91da7ae
Compare
karenetheridge
force-pushed
the
ether/more-ipv6-tests
branch
from
91da7ae to
4a4384a
Compare
Julian
reviewed
Jul 12, 2020
| }, | ||
| { | ||
| "description": "ipv4-mapped ipv6 address", | ||
| "data": "::ffff:192.168.0.1", |
Member
There was a problem hiding this comment.
This isn't already covered by "mixed format with the ipv4 section as decimal octets"?
Member
Author
There was a problem hiding this comment.
not quite.. I'll amend the test description.
Julian
reviewed
Jul 12, 2020
| }, | ||
| { | ||
| "description": "missing leading octet is invalid", | ||
| "data": ":2:3:4:5:6:7:8", |
Member
There was a problem hiding this comment.
Might be a bit clearer if these tests were right next to the valid versions of them? (I.e. double leading colons and double trailing colons)?
Julian
reviewed
Jul 12, 2020
Member
Julian
left a comment
Julian
left a comment
There was a problem hiding this comment.
Think these mostly seem good. 2 minor comments, but otherwise -- can you backport these? And then likely lgtm.
Member
Author
|
right, I forgot that ipv6 is defined in earlier drafts too :) backported as far as draft4. squash commit added. |
Member
|
lgtm! |
karenetheridge
force-pushed
the
ether/more-ipv6-tests
branch
from
e6819c9 to
04ddab1
Compare
Member
Author
|
rebased, squashed, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug in my implementation 🐙 -- "127.0.0.1" was matching as an ipv6, because the number of octets was not being counted!