Add PHP specifics. #55
Conversation
|
Awesome, thanks for this (and apologies for the late reply--I've been on vacation). I need to look into the Travis failure--I'm pretty sure it's unrelated to your PR. I don't know much about using JSONSchema in PHP so I have to pretty much take your word for it, though based on what I do know about PHP everything looks like it makes sense. |
embray
left a comment
embray
left a comment
There was a problem hiding this comment.
Some minor nitpicks aside looks good to me.
| --Ruby | ||
| In Ruby, "boolean" is analogous to ``TrueClass`` and ``FalseClass``. Note | ||
| that in Ruby there is no ``Boolean`` class. | ||
| --Python |
There was a problem hiding this comment.
I think you meant --PHP here
| |boolean |Boolean | | ||
| +----------+--------------+ | ||
| |null |NULL | | ||
| +----------+--------------+ |
There was a problem hiding this comment.
I'm not really sure whether PHP types should be spelled in upper-case or lower-case. I don't think it really matters since the built-in types are not first-class objects, though gettype() returns the lower-case spelling. Either way I think one spelling should be used consistently (and in some of the examples below you use all lower-case instead).
|
Closing due to lack of activity. |
2 participants
Let me know if I missed anything and feel free to squash the commits.
Fixes #48.