Web release 3 #655

benjagm · 2024-04-15T17:53:46Z

This is the release 3 of the Documentation strategy containing:

New welcome page to the docs:
- Issue: [📑 Docs]: Lets create a welcome page for the docs section #421
- New page: https://web-release-3.website-2v2.pages.dev/overview/welcome
New FAQ page:
- Issue: cookbook page, with solutions to frequently asked questions #190
- New page: https://web-release-3.website-2v2.pages.dev/overview/faq
New Community page:
- Issue: Create a new page for Community inside the Overview Section of the Docs. #280
- New page: https://web-release-3.website-2v2.pages.dev/community
New use cases page:
- Issue: ✨ Enhancement: Create the use cases page #426
- New page: https://web-release-3.website-2v2.pages.dev/overview/case-studies
New case studies page:
- Issue: ✨ Enhancement: Page in overview section to show Case Studies #440
- New page: https://web-release-3.website-2v2.pages.dev/overview/use-cases

* Standardize List Display with Card Component (#433) * Addressed comments, added images, and implemented new styles * Increased padding on the x-axis

* updated UI of blog-page * Added Case Studies Page * fixed linting errors * Added casestudies * changing index.page.tsx * Delete components/CustomComponent.tsx * Delete pages/overview/casestudies.md * removed unnecessary changes * removed unnecessary files * fixed bug * removed changes * removed unnecessary files * Pushing last changes. --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>

* fixed * feat: added resource section * feat: added resource section * revert changes cd6d848 * revert changes 65e9f3e * revert changes 877b0f0 * revert changes 74711cd * fix: fixed the width issue * revert change * fix: added resource icon * Tiny changes to adjust look and feel. * Last changes to fix dark theme --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>

* initialize the Test directory. * Added the subscribe button. * Added the subscribe page. * Added the newsletter page. * changed name to newsletter. * removed the unwated code. * removed the unwated components. * decreased the horizontal width and changed the color. * decreased the font size. * Added the changes for the newsletter banner. * Added the newletter component to landing page. * added the color for input. * Added the required horizontal padding. * Added the required horizontal padding. for newsletter page. * Add changes to make it work with mailchimp * added the yarn file back. * Added yarn.lock file. * Update yarn.lock * linted the newsletter.tsx * linted newsletter * fix the index.page * Small improvement in page layout. * Fix dark theme behavior * . --------- Co-authored-by: AyushNautiyalDeveloper <ayush@betalectic.com> Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>

* added welcome page * Pushed some changes to changes - Better location in sidebar - Changes to move what is json schema into getting started - move page inside overview --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>

* added use-cases page, modified card component * fix * Added some changes to better merge with the dev branch. --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>

* docs: added definition of json hyper-schema * fixed * fix: spacing b/w buttons * fix: added spacing in mobile design * fix: spacing on tablet screen * fix: spacing on less than 300px screen

* community-page * Some final changes for the community page --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>

cloudflare-pages · 2024-04-15T18:00:54Z

Deploying website with Cloudflare Pages

Latest commit:	`c3478f4`
Status:	✅ Deploy successful!
Preview URL:	https://4a1656e5.website-2v2.pages.dev
Branch Preview URL:	https://web-release-3.website-2v2.pages.dev

View logs

* cleaning * changing axios to fs * Remove articles from sidebar --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>

benjagm · 2024-05-20T10:18:57Z

@DhairyaMajmudar can you continue with the work of this PR?

DhairyaMajmudar · 2024-05-20T11:21:38Z

Sure thing looking forward to continue the work on this :D

* Update index.page.tsx Edited the placeholder texts for the welcome page. * fixed lint error * Edited wordings for the Welcome page of release 3 * Update pages/overview/welcome/index.page.tsx Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com> * Update pages/overview/welcome/index.page.tsx Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com> * Remove data duplication and fix intro text --------- Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com> Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>

* removing newsletter * removing resources * removing resources.yml file * removing resources from welcomee page --------- Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com>

…bsite into web-release-3

aialok · 2024-05-29T07:50:48Z

components/Card.tsx

+  return (
+    <div className='group relative h-full w-full rounded-lg border border-gray-200 bg-white p-6 px-12 shadow-3xl dark:shadow-2xl dark:shadow-slate-900 transition-colors ease-in-out hover:bg-slate-100 dark:bg-slate-800 hover:dark:bg-slate-900/30'>
+      <div className='flex justify-center '>
+        {image && <img src={image} className='h-32 p-2' />}


I think it is better to use Next.js prebuilt Image Component. It does some optimization under the hood.

https://nextjs.org/learn-pages-router/seo/improve/images
https://nextjs.org/docs/pages/building-your-application/optimizing/images

aialok · 2024-05-29T07:51:18Z

components/Card.tsx

+      <div className='flex flex-row items-start mb-6'>
+        {icon && (
+          <span className='mr-6 flex h-14 w-14 flex-shrink-0 items-center justify-center rounded-lg border bg-blue-200 px-3 text-gray-900 dark:text-white'>
+            <img src={icon} alt={title} className='h-full w-full' />


Better to use Next.js prebuilt Image Component.

aialok · 2024-05-29T07:51:42Z

components/DarkModeToggle.tsx

@@ -31,7 +31,7 @@ export default function DarkModeToggle() {
  return (
    <button
      onClick={toggleDarkMode}
-      className='dark-mode-toggle rounded-md dark:hover:bg-gray-700 p-1.5 hover:bg-gray-100 focus:bg-gray-100 focus:outline-none transition duration-150'
+      className='dark-mode-toggle min-w-[2rem] rounded-md dark:hover:bg-gray-700 md:p-1.5 pr-2 hover:bg-gray-100 focus:bg-gray-100 focus:outline-none transition duration-150'
      disabled={!isClickable}
    >
      <img src={img} alt='Dark Mode' width={25} height={25} />


Better to use Next.js prebuilt Image Component.

benjagm · 2024-05-30T09:30:44Z

Note for reviewers:

The review we are expecting from this PR is just the content, the technical part has been reviewed with the referenced PRs.

Relequestual

Overall, this is huge progress and represents a great step forward in making JSON Schema more presentable to first time users and those with a vague passing familiarity. Thank you to everyone involved!

I've left a number of suggestions for changes, and a number of questions and comments.
I do think some work is needed before this should go live, but most of it is minor.

.github/workflows/greet_on_first_merge.yml

public/img/event/meet.png

styles/globals.css

components/Faq.tsx

pages/overview/what-is-jsonschema.md

data/community.json

data/welcome.json

data/case-studies.json

Co-authored-by: Ben Hutton <relequestual@gmail.com>

DhairyaMajmudar · 2024-06-01T15:22:41Z

We are still facing bugs related to width in the FAQ section which can be fixed if we add one more line in the paragraph below

Co-authored-by: Ben Hutton <relequestual@gmail.com>

…JSON Schema (#724) * Adding feedback to improve the messaging and illustration * Change back the new illustration to SVG format * Added the comments provided by Ben Hutton in PR #655 * Update pages/overview/what-is-jsonschema.md Co-authored-by: Ben Hutton <relequestual@gmail.com> * Update pages/overview/what-is-jsonschema.md Co-authored-by: Greg Dennis <gregsdennis@yahoo.com> * Adding last requested changes --------- Co-authored-by: Ben Hutton <relequestual@gmail.com> Co-authored-by: Greg Dennis <gregsdennis@yahoo.com>

Michael-Obele and others added 12 commits March 20, 2024 10:36

Standardize List Display with Card Component (#433) (#460)

7c5c331

* Standardize List Display with Card Component (#433) * Addressed comments, added images, and implemented new styles * Increased padding on the x-axis

feat: added Faq section (#534)

3c3c5f6

Fix faq

46a922b

Added welcome page (#566)

8a32db3

* added welcome page * Pushed some changes to changes - Better location in sidebar - Changes to move what is json schema into getting started - move page inside overview --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>

Added Use-cases page (#589)

3647457

* added use-cases page, modified card component * fix * Added some changes to better merge with the dev branch. --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>

Change docs link

2cda0bc

fix: spacing between buttons (#575)

f45b548

* docs: added definition of json hyper-schema * fixed * fix: spacing b/w buttons * fix: added spacing in mobile design * fix: spacing on tablet screen * fix: spacing on less than 300px screen

community-page (#646)

a22a799

* community-page * Some final changes for the community page --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>

Merge branch 'main' into web-release-3

abbcc0a

benjagm and others added 7 commits April 15, 2024 20:10

Update Sidebar.tsx

fb98b60

Add resources file

3958b6d

Update Sidebar.tsx

c8599e0

Update case-studies.json

373f64e

Text colours for dark theme

f7e6fd5

New version of the implementers page

7995844

Feat: Replacing Axios to fs fetching in resources page (#657)

c04d577

* cleaning * changing axios to fs * Remove articles from sidebar --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>

benjagm and others added 8 commits May 20, 2024 18:33

Improve Case Studies and Use Cases welcome messages

886ee85

adding codeowners

ee91a74

Fixing bugs and adding back lost files

69a1eae

fix sidebar dropdown for FAQ

989ded0

community page major changes and faq bug fix

290e4de

community page bug fixes and responsive issues in several pages

515f95c

Feat: Removing resources and newletter from web-release-3 branch (#698)

3991da0

* removing newsletter * removing resources * removing resources.yml file * removing resources from welcomee page --------- Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com>

benjagm marked this pull request as ready for review May 28, 2024 09:51

benjagm requested a review from a team as a code owner May 28, 2024 09:51

benjagm and others added 5 commits May 28, 2024 11:57

Improvement for case studies

e8dc9bc

Merge branch 'web-release-3' of https://github.com/json-schema-org/we…

2954b0c

…bsite into web-release-3

merge confilts

a00c819

removing merge conflicts

7b13f8e

Fix:community card gap

c3f2a06

aialok reviewed May 29, 2024

View reviewed changes

Relequestual requested changes May 30, 2024

View reviewed changes

benjagm and others added 6 commits May 30, 2024 17:21

Align with main branch

5c4acaa

Align with main branch

0898f7b

Align with main branch

3af14b5

Update pages/overview/what-is-jsonschema.md

647d52c

Co-authored-by: Ben Hutton <relequestual@gmail.com>

Remove welcome data file

ae04e43

Merge branch 'main' into web-release-3

46e4dcd

benjagm added a commit that referenced this pull request Jun 1, 2024

Added the comments provided by Ben Hutton in PR #655

02ae82b

benjagm mentioned this pull request Jun 1, 2024

Adding feedback to improve the messaging and illustration of What is JSON Schema #724

Merged

benjagm and others added 3 commits June 1, 2024 12:45

Move welcome outside overview section

1f56a4a

Change welcome text

73aec68

Feat: Replaced axios with fetch

b1e68ad

DhairyaMajmudar and others added 4 commits June 2, 2024 11:22

moved path to function

4a53960

Updating community filters

0b0fb2d

Update pages/community/index.page.tsx

6b51f02

Co-authored-by: Ben Hutton <relequestual@gmail.com>

Fix the menu links

0662ac9

Update the JSON Schema calendar link

c3478f4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Web release 3 #655

Web release 3 #655

benjagm commented Apr 15, 2024 •

edited

cloudflare-pages bot commented Apr 15, 2024 •

edited

benjagm commented May 20, 2024

DhairyaMajmudar commented May 20, 2024

aialok May 29, 2024

aialok May 29, 2024

aialok May 29, 2024

benjagm commented May 30, 2024

Relequestual left a comment

DhairyaMajmudar commented Jun 1, 2024

Web release 3 #655

Are you sure you want to change the base?

Web release 3 #655

Conversation

benjagm commented Apr 15, 2024 • edited

cloudflare-pages bot commented Apr 15, 2024 • edited

Deploying website with Cloudflare Pages

benjagm commented May 20, 2024

DhairyaMajmudar commented May 20, 2024

aialok May 29, 2024

Choose a reason for hiding this comment

aialok May 29, 2024

Choose a reason for hiding this comment

aialok May 29, 2024

Choose a reason for hiding this comment

benjagm commented May 30, 2024

Relequestual left a comment

Choose a reason for hiding this comment

DhairyaMajmudar commented Jun 1, 2024

benjagm commented Apr 15, 2024 •

edited

cloudflare-pages bot commented Apr 15, 2024 •

edited