-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web release 3 #655
base: main
Are you sure you want to change the base?
Web release 3 #655
Conversation
* updated UI of blog-page * Added Case Studies Page * fixed linting errors * Added casestudies * changing index.page.tsx * Delete components/CustomComponent.tsx * Delete pages/overview/casestudies.md * removed unnecessary changes * removed unnecessary files * fixed bug * removed changes * removed unnecessary files * Pushing last changes. --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
* fixed * feat: added resource section * feat: added resource section * revert changes cd6d848 * revert changes 65e9f3e * revert changes 877b0f0 * revert changes 74711cd * fix: fixed the width issue * revert change * fix: added resource icon * Tiny changes to adjust look and feel. * Last changes to fix dark theme --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
* initialize the Test directory. * Added the subscribe button. * Added the subscribe page. * Added the newsletter page. * changed name to newsletter. * removed the unwated code. * removed the unwated components. * decreased the horizontal width and changed the color. * decreased the font size. * Added the changes for the newsletter banner. * Added the newletter component to landing page. * added the color for input. * Added the required horizontal padding. * Added the required horizontal padding. for newsletter page. * Add changes to make it work with mailchimp * added the yarn file back. * Added yarn.lock file. * Update yarn.lock * linted the newsletter.tsx * linted newsletter * fix the index.page * Small improvement in page layout. * Fix dark theme behavior * . --------- Co-authored-by: AyushNautiyalDeveloper <ayush@betalectic.com> Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
* added welcome page * Pushed some changes to changes - Better location in sidebar - Changes to move what is json schema into getting started - move page inside overview --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
* added use-cases page, modified card component * fix * Added some changes to better merge with the dev branch. --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
* docs: added definition of json hyper-schema * fixed * fix: spacing b/w buttons * fix: added spacing in mobile design * fix: spacing on tablet screen * fix: spacing on less than 300px screen
* community-page * Some final changes for the community page --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
Deploying website with Cloudflare Pages
|
* cleaning * changing axios to fs * Remove articles from sidebar --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
@DhairyaMajmudar can you continue with the work of this PR? |
Sure thing looking forward to continue the work on this :D |
* Update index.page.tsx Edited the placeholder texts for the welcome page. * fixed lint error * Edited wordings for the Welcome page of release 3 * Update pages/overview/welcome/index.page.tsx Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com> * Update pages/overview/welcome/index.page.tsx Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com> * Remove data duplication and fix intro text --------- Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com> Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
* removing newsletter * removing resources * removing resources.yml file * removing resources from welcomee page --------- Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com>
return ( | ||
<div className='group relative h-full w-full rounded-lg border border-gray-200 bg-white p-6 px-12 shadow-3xl dark:shadow-2xl dark:shadow-slate-900 transition-colors ease-in-out hover:bg-slate-100 dark:bg-slate-800 hover:dark:bg-slate-900/30'> | ||
<div className='flex justify-center '> | ||
{image && <img src={image} className='h-32 p-2' />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to use Next.js prebuilt Image
Component. It does some optimization under the hood.
https://nextjs.org/learn-pages-router/seo/improve/images
https://nextjs.org/docs/pages/building-your-application/optimizing/images
<div className='flex flex-row items-start mb-6'> | ||
{icon && ( | ||
<span className='mr-6 flex h-14 w-14 flex-shrink-0 items-center justify-center rounded-lg border bg-blue-200 px-3 text-gray-900 dark:text-white'> | ||
<img src={icon} alt={title} className='h-full w-full' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to use Next.js prebuilt Image Component.
components/DarkModeToggle.tsx
Outdated
@@ -31,7 +31,7 @@ export default function DarkModeToggle() { | |||
return ( | |||
<button | |||
onClick={toggleDarkMode} | |||
className='dark-mode-toggle rounded-md dark:hover:bg-gray-700 p-1.5 hover:bg-gray-100 focus:bg-gray-100 focus:outline-none transition duration-150' | |||
className='dark-mode-toggle min-w-[2rem] rounded-md dark:hover:bg-gray-700 md:p-1.5 pr-2 hover:bg-gray-100 focus:bg-gray-100 focus:outline-none transition duration-150' | |||
disabled={!isClickable} | |||
> | |||
<img src={img} alt='Dark Mode' width={25} height={25} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to use Next.js prebuilt Image Component.
Note for reviewers: The review we are expecting from this PR is just the content, the technical part has been reviewed with the referenced PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is huge progress and represents a great step forward in making JSON Schema more presentable to first time users and those with a vague passing familiarity. Thank you to everyone involved!
I've left a number of suggestions for changes, and a number of questions and comments.
I do think some work is needed before this should go live, but most of it is minor.
Co-authored-by: Ben Hutton <relequestual@gmail.com>
Co-authored-by: Ben Hutton <relequestual@gmail.com>
…JSON Schema (#724) * Adding feedback to improve the messaging and illustration * Change back the new illustration to SVG format * Added the comments provided by Ben Hutton in PR #655 * Update pages/overview/what-is-jsonschema.md Co-authored-by: Ben Hutton <relequestual@gmail.com> * Update pages/overview/what-is-jsonschema.md Co-authored-by: Greg Dennis <gregsdennis@yahoo.com> * Adding last requested changes --------- Co-authored-by: Ben Hutton <relequestual@gmail.com> Co-authored-by: Greg Dennis <gregsdennis@yahoo.com>
This is the release 3 of the Documentation strategy containing:
New welcome page to the docs:
New FAQ page:
New Community page:
New use cases page:
New case studies page: