Feat/custom protocols alt #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelfordZ
force-pushed
the
feat/custom-protocols-alt
branch
from
a140dae to
c895169
Compare
shanejonas
previously approved these changes
May 6, 2021
|
needs rebase |
Add the ability to implement custom protocols easily.
BelfordZ
force-pushed
the
feat/custom-protocols-alt
branch
from
c895169 to
61ef640
Compare
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having seen #146 I put this together as what I think is an extension of @raman-kananovich 's work.
I quite liked his reference loader interface, specfically having a method to test if its 'fetchable' by the particular protocol handler.
The difference is mainly in the interface, but also had to do with cleaning up some initial hacked-together techdebt if you will.
Raman, thank you very mcuh for the PR and taking the time to help get this together!
fixes: