Fix import ref rewriting #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rging When importing schemas via $import or $importdefs, internal $ref and $extends pointers (like #/definitions/Address) were pointing to the original document's root instead of their new location in the merged document. This fix adds a _rewrite_refs helper method to both validators that recursively rewrites these pointers to their new location after import. For example, when importing at #/definitions/People, a reference like #/definitions/Address is rewritten to #/definitions/People/Address. Changes: - Added _rewrite_refs() method to both validators - Updated _process_imports() to call ref rewriting with deep copy - Added 3 new tests for ref rewriting scenarios Fixes #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2