yaml: tolerate unquoted comma-separated number pairs#11
Merged
Conversation
The digit-prefix branch of the YAML matcher only handled trailing commas (e.g. "12,"). Inputs like "key: 1, 2" or "- 1.5, 2.5" reached jsonic's number matcher, which grabbed the leading digits and left the rest of the line to error out as "unexpected character(s): 2". In block context, commas are valid plain-scalar characters (the text-prefix path already handled "key: foo, bar"). Embedded commas now route through text.check (via skipNumberMatch), so the whole plain scalar — including spaces and multi-line continuation — is captured. Flow-context comma semantics are unchanged. Mirrored in go/yaml.go for parity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The digit-prefix branch of the YAML matcher only handled trailing
commas (e.g. "12,"). Inputs like "key: 1, 2" or "- 1.5, 2.5" reached
jsonic's number matcher, which grabbed the leading digits and left
the rest of the line to error out as "unexpected character(s): 2".
In block context, commas are valid plain-scalar characters (the
text-prefix path already handled "key: foo, bar"). Embedded commas
now route through text.check (via skipNumberMatch), so the whole
plain scalar — including spaces and multi-line continuation — is
captured. Flow-context comma semantics are unchanged.
Mirrored in go/yaml.go for parity.