Extend render template with common usage & install instructions#27
Merged
Extend render template with common usage & install instructions#27
Conversation
Duologic
force-pushed
the
duologic/extend_template_jb
branch
from
5104530 to
9169578
Compare
Duologic
force-pushed
the
duologic/extend_template_jb
branch
from
9169578 to
0679c75
Compare
Duologic
changed the title
malcolmholmes
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds install instructions with jsonnet-bundler to the jsonnet renderer.
I took the opportunity to give the author the ability to extend the template for the install and usage instructions, this way the documentation can be enriched with more useful example while keeping a generic structure.
I have not backported these into the Golang binary but kept it backwards compatible.