feat(ascii): implement f() to validate string as number according to JSON specification #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
julienduchesne
left a comment
julienduchesne
left a comment
There was a problem hiding this comment.
Should it be a new function? IsStringJSONNumber or something. This modifies the current functionality and the behavior being implemented here would me unexpected to me, considering the function name.
Duologic
changed the title
Duologic
changed the title
julienduchesne
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides checking whether the characters are all digits,
ascii.isStringJSONNumericcan also deal with negative numbers, fractions and exponents.I've implemented this according to https://www.json.org/json-en.html, I found the notation on https://www.crockford.com/mckeeman.html easier to read.