-
-
Notifications
You must be signed in to change notification settings - Fork 365
Enhancement: Add .editorconfig #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| trim_trailing_whitespace = false | ||
|
|
||
| [*.yml] | ||
| indent_size = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this configuration reflects what is mostly used within this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While these settings may reflect current usage, they aren't necessarily desirable, and we should probably have a discussion around indentation particularly.
I'd rather like to see the entire project move to a 4-space indent, unless anyone else objects. What we have now is largely historical, and comes from a very old codebase with none of the original maintaners remaining.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, @erayd!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@localheinz shall we move to 4 space indention and move this forward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do! Been busy today with tax preparation. Taking a look tomorrow!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the indentation! π
f5e9fc2 to
3a60c09
Compare
44850ce to
6651e1b
Compare
6651e1b to
f19a261
Compare
This PR
.editorconfigπββοΈ For reference, see http://editorconfig.org.