Allow underscore and tilde in URI hostnames as per RFC 3986 #853
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of RFC 3986 in the URI validator is more strict than the specification allows. While the RFC says
the host component grammar actually allows more characters than are allowed in DNS names.
This is a problem for the Drupal project which uses this package in conjunction with custom stream wrappers with module names in the host component. Module names conform to PHP function name standards, not DNS standards - that is, they allow underscores but not dashes.
The relevant RFC grammar is
This PR widens the
hostvalidation to allow all characters in theunreservedset. Whilepct-encodedandsub-delimsare also technically allowed, this is the smallest change that will help us out.