Update php-enum dependency version to ^4.4 #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, Versions of `mark-mabe/php-enum` lower than 4.4 emit a warning on PHP 8: ``` PHP Warning: Private methods cannot be final as they are never overridden by other classes ``` so it would be nice to restrict installs to versions that work fine. There is no BC breaks with this and no change in dependencies.
Collaborator
DannyvdSluijs
left a comment
DannyvdSluijs
left a comment
There was a problem hiding this comment.
Nice work. Very clean PR solving one single issue, love it.
Could you also include a changelog entry? This way I can quickly merge and make a patch release.
Contributor
Author
|
@DannyvdSluijs Done! |
DannyvdSluijs
approved these changes
Dec 2, 2025
DannyvdSluijs
pushed a commit
that referenced
this pull request
Dec 2, 2025
Collaborator
|
Released as part of |
Contributor
Author
|
Thanks @DannyvdSluijs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi,
Versions of
mark-mabe/php-enumlower than 4.4 emit a warning on PHP 8:so it would be nice to restrict installs to versions that work fine. There is no BC breaks with this and no change in dependencies.
Type of Change
Checklist