Skip to content

Conversation

@maxbeatty
Copy link
Member

mostly fixes #247

  1. you can now add more code snippets 🎆
  2. once you add a code snippet, there's no way to remove it 😬

the broken logic was in the footer due to missing template variables. needed benchmark === false && mainJS === true to get jQuery and the JS that adds button client side

@maxbeatty maxbeatty self-assigned this Jan 9, 2017
};

exports.testPageContext = {
home: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decided to separate these template logic vars from the test defaults. not DRY but easier to reason about

@mathiasbynens mathiasbynens merged commit 5cfc41d into master Jan 9, 2017
@mathiasbynens
Copy link
Contributor

once you add a code snippet, there's no way to remove it 😬

This was the case in the original version of jsPerf, too. However, if you left a code snippet field + its title empty, it wouldn’t be added to the database.

@maxbeatty maxbeatty deleted the fix-edit-page-add-test branch January 9, 2017 17:09
@maxbeatty
Copy link
Member Author

Since Joi validates the entire form payload it's not easy (if possible) to make rule exceptions. Created #309 to track

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When editing, no option to add a code snippet

3 participants