Skip to content

fix(UI/UX): add a validation step before leaving scope #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crowlKats merged 6 commits into from
May 29, 2025
Merged

fix(UI/UX): add a validation step before leaving scope #952

crowlKats merged 6 commits into from
May 29, 2025

Conversation

@AugustinMauroy
Copy link
Contributor

@AugustinMauroy AugustinMauroy commented Feb 10, 2025 •
edited
Loading

#947

Visual

@crowlKats
Copy link
Collaborator

crowlKats commented Feb 25, 2025

The input box looks very different from our other input boxes. can you maybe copy the styling?

@AugustinMauroy
Copy link
Contributor Author

AugustinMauroy commented Feb 26, 2025 •
edited
Loading

The input box looks very different from our other input boxes. can you maybe copy the styling?

Capture d’écran 2025-02-26 à 10 20 38

@AugustinMauroy AugustinMauroy changed the title Fix(UI/UX): add a validation step before leaving scope fix(UI/UX): add a validation step before leaving scope Feb 26, 2025
@crowlKats
Copy link
Collaborator

crowlKats commented Mar 11, 2025

just tested locally: while i am typing i get the error popup. this is not great, especially since it shifts the entire layout. there should be some input debouncing.

@AugustinMauroy
Copy link
Contributor Author

AugustinMauroy commented Apr 17, 2025

Layout shift should be removed.

@AugustinMauroy AugustinMauroy marked this pull request as draft April 26, 2025 09:50
@AugustinMauroy AugustinMauroy marked this pull request as ready for review April 26, 2025 09:53
@AugustinMauroy
Copy link
Contributor Author

AugustinMauroy commented May 4, 2025

bump @crowlKats

@crowlKats crowlKats added this pull request to the merge queue May 29, 2025
Merged via the queue into jsr-io:main with commit 99957cb May 29, 2025
7 checks passed
@AugustinMauroy AugustinMauroy deleted the fix-ui-leave branch May 29, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AugustinMauroy @crowlKats