Conversation
| } | ||
| } | ||
|
|
||
| export class State { |
There was a problem hiding this comment.
diff got kind of butchered here since it prioritized my move of the sampleFormulaCode
| .then((result) => { | ||
| globals = State.load(JSON.parse(result)); | ||
| globals.load(JSON.parse(result)); | ||
| globals.imageOpen = false; |
There was a problem hiding this comment.
now have to explicitly close the modal since we aren't just relying on the state being wiped. This is probably better to be controlled explicitly imo - you could also handle errors better/show confirmation if you wanted to for example
|
I think this should instead be solvable by fixing how the All that being said, I'm not sure of the best way to solve the root problem. Possibly with some use of Svelte's I'm not going to merge this PR as-is because this requires further thought and investigation. |
|
Closing in favor of #2 |
Idea here is to separate out the loadable part of the state since replacing the entire state object leads to
elementsbeing overwritten, which should be durable through loads.The reproduction for the bug is to load a sheet from the Save/Load image modal. Then try pressing
iwhile in normal mode in a cell. It will fail to focus the formula bar with an error like this: