Replace action sprite with FontAwesome

Summary: Replaces the action icons in action headers with FontAwesome

Test Plan:
- grep SPRITE_ACTIONS
- grep sprite-actions
- Replace on UIExamples
- Replace on Workboards
- Replace on Dashboards
- Replace on FeedStories

{F157840}
{F157841}

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9230

Author: chadlittle

resources/celerity/map.php

@@ -7,7 +7,7 @@
 return array(
   'names' =>
   array(
-    'core.pkg.css' => '865102d6',
+    'core.pkg.css' => '3445a3a7',
     'core.pkg.js' => 'ab0d6d3d',
     'darkconsole.pkg.js' => 'ca8671ce',
     'differential.pkg.css' => '382ca868',
@@ -113,8 +113,8 @@
     'rsrc/css/diviner/diviner-shared.css' => '38813222',
     'rsrc/css/font/font-awesome.css' => '73d075c3',
     'rsrc/css/font/font-source-sans-pro.css' => '91d53463',
-    'rsrc/css/font/phui-font-icon-base.css' => '74cfb6a9',
-    'rsrc/css/layout/phabricator-action-header-view.css' => '0c333cad',
+    'rsrc/css/font/phui-font-icon-base.css' => '3b2f9260',
+    'rsrc/css/layout/phabricator-action-header-view.css' => '40134802',
     'rsrc/css/layout/phabricator-action-list-view.css' => 'dcd9875f',
     'rsrc/css/layout/phabricator-crumbs-view.css' => '6a23399c',
     'rsrc/css/layout/phabricator-filetree-view.css' => 'a8c86ace',
@@ -128,12 +128,12 @@
     'rsrc/css/phui/phui-box.css' => '7b3a2eed',
     'rsrc/css/phui/phui-button.css' => '3dbdbf0d',
     'rsrc/css/phui/phui-document.css' => '3b078dc0',
-    'rsrc/css/phui/phui-feed-story.css' => '3a59c2cf',
+    'rsrc/css/phui/phui-feed-story.css' => '37216a85',
     'rsrc/css/phui/phui-fontkit.css' => 'de84aa4a',
     'rsrc/css/phui/phui-form-view.css' => '867463b4',
     'rsrc/css/phui/phui-form.css' => 'b78ec020',
     'rsrc/css/phui/phui-header-view.css' => '689dbc38',
-    'rsrc/css/phui/phui-icon.css' => 'ef701b9b',
+    'rsrc/css/phui/phui-icon.css' => 'cdcf2aca',
     'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
     'rsrc/css/phui/phui-list.css' => 'ce29d035',
     'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec',
@@ -148,7 +148,6 @@
     'rsrc/css/phui/phui-timeline-view.css' => '15ff2a9f',
     'rsrc/css/phui/phui-workboard-view.css' => '2bf82d00',
     'rsrc/css/phui/phui-workpanel-view.css' => 'fddd97bf',
-    'rsrc/css/sprite-actions.css' => '969ad0e5',
     'rsrc/css/sprite-apps-large.css' => '76d8716b',
     'rsrc/css/sprite-apps-xlarge.css' => 'db66c878',
     'rsrc/css/sprite-apps.css' => '600df7dd',
@@ -308,8 +307,6 @@
     'rsrc/image/phrequent_inactive.png' => 'bfc15a69',
     'rsrc/image/search-white.png' => '64cc0d45',
     'rsrc/image/search.png' => '82625a7e',
-    'rsrc/image/sprite-actions-X2.png' => '7dfd5652',
-    'rsrc/image/sprite-actions.png' => '2ddd18c3',
     'rsrc/image/sprite-apps-X2.png' => '55b68035',
     'rsrc/image/sprite-apps-large-X2.png' => 'becb43e7',
     'rsrc/image/sprite-apps-large.png' => '6c673dd5',
@@ -691,7 +688,7 @@
     'paste-css' => 'aa1767d1',
     'path-typeahead' => 'f7fc67ec',
     'people-profile-css' => 'ba7b2762',
-    'phabricator-action-header-view-css' => '0c333cad',
+    'phabricator-action-header-view-css' => '40134802',
     'phabricator-action-list-view-css' => 'dcd9875f',
     'phabricator-application-launch-view-css' => 'd290ba21',
     'phabricator-busy' => '6453c869',
@@ -761,13 +758,13 @@
     'phui-calendar-list-css' => 'c1d0ca59',
     'phui-calendar-month-css' => 'a92e47d2',
     'phui-document-view-css' => '3b078dc0',
-    'phui-feed-story-css' => '3a59c2cf',
-    'phui-font-icon-base-css' => '74cfb6a9',
+    'phui-feed-story-css' => '37216a85',
+    'phui-font-icon-base-css' => '3b2f9260',
     'phui-fontkit-css' => 'de84aa4a',
     'phui-form-css' => 'b78ec020',
     'phui-form-view-css' => '867463b4',
     'phui-header-view-css' => '689dbc38',
-    'phui-icon-view-css' => 'ef701b9b',
+    'phui-icon-view-css' => 'cdcf2aca',
     'phui-info-panel-css' => '27ea50a1',
     'phui-list-view-css' => 'ce29d035',
     'phui-object-box-css' => 'ce92d8ec',
@@ -800,7 +797,6 @@
     'releeph-request-differential-create-dialog' => '8d8b92cd',
     'releeph-request-typeahead-css' => '667a48ae',
     'setup-issue-css' => '69e640e7',
-    'sprite-actions-css' => '969ad0e5',
     'sprite-apps-css' => '600df7dd',
     'sprite-apps-large-css' => '76d8716b',
     'sprite-apps-xlarge-css' => 'db66c878',

resources/sprite/manifest/actions.json

@@ -30,7 +30,6 @@
   'remarkup' => $generator->buildRemarkupSheet(),
   'menu' => $generator->buildMenuSheet(),
   'apps' => $generator->buildAppsSheet(),
-  'actions' => $generator->buildActionsSheet(),
   'minicons' => $generator->buildMiniconsSheet(),
   'conpherence' => $generator->buildConpherenceSheet(),
   'apps-large' => $generator->buildAppsLargeSheet(),

scripts/celerity/generate_sprites.php

@@ -66,8 +66,7 @@ private function renderWidgetPaneContent() {
 
     $widgets = array();
     $new_icon = id(new PHUIIconView())
-      ->setSpriteSheet(PHUIIconView::SPRITE_ACTIONS)
-      ->setSpriteIcon('new-grey')
+      ->setIconFont('fa-plus')
       ->setHref($this->getWidgetURI())
       ->setMetadata(array('widget' => null))
       ->addSigil('conpherence-widget-adder');

src/applications/conpherence/controller/ConpherenceWidgetController.php

@@ -229,8 +229,7 @@ private function addPanelHeaderActions(
       $edit_uri->setQueryParam('dashboardID', $dashboard_id);
     }
     $action_edit = id(new PHUIIconView())
-      ->setSpriteSheet(PHUIIconView::SPRITE_ACTIONS)
-      ->setSpriteIcon('settings-grey')
+      ->setIconFont('fa-pencil')
       ->setHref((string) $edit_uri);
     $header->addAction($action_edit);
 
@@ -239,8 +238,7 @@ private function addPanelHeaderActions(
         '/dashboard/removepanel/'.$dashboard_id.'/'))
         ->setQueryParam('panelPHID', $panel->getPHID());
       $action_remove = id(new PHUIIconView())
-        ->setSpriteSheet(PHUIIconView::SPRITE_ACTIONS)
-        ->setSpriteIcon('close-grey')
+        ->setIconFont('fa-trash-o')
         ->setHref((string) $uri)
         ->setWorkflow(true);
       $header->addAction($action_remove);

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

@@ -165,8 +165,7 @@ public function processRequest() {
         $panel->setEditURI('column/'.$column->getID().'/');
       }
       $panel->setHeaderAction(id(new PHUIIconView())
-        ->setSpriteSheet(PHUIIconView::SPRITE_ACTIONS)
-        ->setSpriteIcon('new-grey')
+        ->setIconFont('fa-plus')
         ->setHref('/maniphest/task/create/')
         ->addSigil('column-add-task')
         ->setMetadata(

src/applications/project/controller/PhabricatorProjectBoardViewController.php

@@ -66,8 +66,7 @@ public function renderExample() {
     $text = hsprintf('<strong><a>harding (Tom Harding)</a></strong> awarded '.
       '<a>M10: Workboards</a> a token.');
     $action1 = id(new PHUIIconView())
-      ->setSpriteSheet(PHUIIconView::SPRITE_ACTIONS)
-      ->setSpriteIcon('token-grey')
+      ->setIconFont('fa-trophy bluegrey')
       ->setHref('#');
     $token =
         id(new PHUIIconView())
@@ -87,12 +86,10 @@ public function renderExample() {
     $text = hsprintf('<strong><a>wgharding (Warren Harding)</a></strong> '.
       'asked a new question.');
     $action1 = id(new PHUIIconView())
-      ->setSpriteSheet(PHUIIconView::SPRITE_ACTIONS)
-      ->setSpriteIcon('up-grey')
+      ->setIconFont('fa-chevron-up bluegrey')
       ->setHref('#');
     $action2 = id(new PHUIIconView())
-      ->setSpriteSheet(PHUIIconView::SPRITE_ACTIONS)
-      ->setSpriteIcon('down-grey')
+      ->setIconFont('fa-chevron-down bluegrey')
       ->setHref('#');
     $story4 = id(new PHUIFeedStoryView())
       ->setTitle($text)