FontAwesome RemarkupBar

Summary:
Replaces the icons with fonts from FontAwesome. Up in the air about the meme icon. Thoughts?

Also removed the second fullscreen/normal state. Seems obvious what it does, but assume someone complained previously?

Test Plan:
Tested all the icon states and made sure they still worked. Test fullscreen and help.

{F163485}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9385

Author: chadlittle

resources/celerity/map.php

@@ -7,8 +7,8 @@
 return array(
   'names' =>
   array(
-    'core.pkg.css' => 'baca3efb',
-    'core.pkg.js' => '29e9786d',
+    'core.pkg.css' => 'd9c53a92',
+    'core.pkg.js' => 'b6689fe1',
     'darkconsole.pkg.js' => 'ca8671ce',
     'differential.pkg.css' => '4a93db37',
     'differential.pkg.js' => 'eca39a2c',
@@ -105,7 +105,7 @@
     'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
     'rsrc/css/application/uiexample/example.css' => '528b19de',
     'rsrc/css/core/core.css' => '40151074',
-    'rsrc/css/core/remarkup.css' => '80c3a48c',
+    'rsrc/css/core/remarkup.css' => 'b510c359',
     'rsrc/css/core/syntax.css' => '3c18c1cb',
     'rsrc/css/core/z-index.css' => 'efb673ac',
     'rsrc/css/diviner/diviner-shared.css' => '38813222',
@@ -157,7 +157,6 @@
     'rsrc/css/sprite-minicons.css' => 'df4f76fe',
     'rsrc/css/sprite-payments.css' => 'cc085d44',
     'rsrc/css/sprite-projects.css' => '7578fa56',
-    'rsrc/css/sprite-remarkup.css' => '5c396a57',
     'rsrc/css/sprite-tokens.css' => '1706b943',
     'rsrc/externals/font/fontawesome/fontawesome-webfont.eot' => '1cab0752',
     'rsrc/externals/font/fontawesome/fontawesome-webfont.ttf' => '2ff84fd2',
@@ -324,8 +323,6 @@
     'rsrc/image/sprite-payments.png' => 'd8576309',
     'rsrc/image/sprite-projects-X2.png' => '218fdc8b',
     'rsrc/image/sprite-projects.png' => '631ff9a7',
-    'rsrc/image/sprite-remarkup-X2.png' => '7ee1dc28',
-    'rsrc/image/sprite-remarkup.png' => 'b4421f07',
     'rsrc/image/sprite-tokens-X2.png' => 'b4776580',
     'rsrc/image/sprite-tokens.png' => '25b75533',
     'rsrc/image/texture/card-gradient.png' => '815f26e8',
@@ -462,7 +459,7 @@
     'rsrc/js/core/behavior-object-selector.js' => 'e6f67523',
     'rsrc/js/core/behavior-oncopy.js' => 'c3e218fe',
     'rsrc/js/core/behavior-phabricator-nav.js' => 'b5842a5e',
-    'rsrc/js/core/behavior-phabricator-remarkup-assist.js' => 'ddee74db',
+    'rsrc/js/core/behavior-phabricator-remarkup-assist.js' => 'ba22863c',
     'rsrc/js/core/behavior-refresh-csrf.js' => '7814b593',
     'rsrc/js/core/behavior-remarkup-preview.js' => 'f7379f45',
     'rsrc/js/core/behavior-reorder-applications.js' => 'a8e3795d',
@@ -605,7 +602,7 @@
     'javelin-behavior-phabricator-notification-example' => 'c51a6616',
     'javelin-behavior-phabricator-object-selector' => 'e6f67523',
     'javelin-behavior-phabricator-oncopy' => 'c3e218fe',
-    'javelin-behavior-phabricator-remarkup-assist' => 'ddee74db',
+    'javelin-behavior-phabricator-remarkup-assist' => 'ba22863c',
     'javelin-behavior-phabricator-reveal-content' => '8f24abfc',
     'javelin-behavior-phabricator-search-typeahead' => '86549ee3',
     'javelin-behavior-phabricator-show-all-transactions' => '7c273581',
@@ -718,7 +715,7 @@
     'phabricator-prefab' => '41ed7994',
     'phabricator-profile-css' => '33e6f703',
     'phabricator-project-tag-css' => '095c9404',
-    'phabricator-remarkup-css' => '80c3a48c',
+    'phabricator-remarkup-css' => 'b510c359',
     'phabricator-search-results-css' => 'f240504c',
     'phabricator-shaped-request' => '7cbe244b',
     'phabricator-side-menu-view-css' => 'a2ccd7bd',
@@ -806,7 +803,6 @@
     'sprite-minicons-css' => 'df4f76fe',
     'sprite-payments-css' => 'cc085d44',
     'sprite-projects-css' => '7578fa56',
-    'sprite-remarkup-css' => '5c396a57',
     'sprite-tokens-css' => '1706b943',
     'subscribers-list-css' => '5bb30c78',
     'syntax-highlighting-css' => '3c18c1cb',
@@ -1692,6 +1688,16 @@
       0 => 'javelin-install',
       1 => 'javelin-dom',
     ),
+    'ba22863c' =>
+    array(
+      0 => 'javelin-behavior',
+      1 => 'javelin-stratcom',
+      2 => 'javelin-dom',
+      3 => 'phabricator-phtize',
+      4 => 'phabricator-textareautils',
+      5 => 'javelin-workflow',
+      6 => 'javelin-vector',
+    ),
     'bc75da74' =>
     array(
       0 => 'javelin-behavior',
@@ -1905,16 +1911,6 @@
       1 => 'javelin-dom',
       2 => 'phabricator-prefab',
     ),
-    'ddee74db' =>
-    array(
-      0 => 'javelin-behavior',
-      1 => 'javelin-stratcom',
-      2 => 'javelin-dom',
-      3 => 'phabricator-phtize',
-      4 => 'phabricator-textareautils',
-      5 => 'javelin-workflow',
-      6 => 'javelin-vector',
-    ),
     'e1ff79b1' =>
     array(
       0 => 'javelin-behavior',
@@ -2132,39 +2128,38 @@
       15 => 'aphront-tooltip-css',
       16 => 'phabricator-flag-css',
       17 => 'aphront-error-view-css',
-      18 => 'sprite-remarkup-css',
-      19 => 'sprite-gradient-css',
-      20 => 'sprite-menu-css',
-      21 => 'sprite-apps-css',
-      22 => 'sprite-apps-large-css',
-      23 => 'phabricator-main-menu-view',
-      24 => 'phabricator-notification-css',
-      25 => 'phabricator-notification-menu-css',
-      26 => 'lightbox-attachment-css',
-      27 => 'phui-header-view-css',
-      28 => 'phabricator-filetree-view-css',
-      29 => 'phabricator-nav-view-css',
-      30 => 'phabricator-side-menu-view-css',
-      31 => 'phabricator-crumbs-view-css',
-      32 => 'phui-object-item-list-view-css',
-      33 => 'global-drag-and-drop-css',
-      34 => 'phui-spacing-css',
-      35 => 'phui-form-css',
-      36 => 'phui-icon-view-css',
-      37 => 'phabricator-application-launch-view-css',
-      38 => 'phabricator-action-list-view-css',
-      39 => 'phui-property-list-view-css',
-      40 => 'phui-tag-view-css',
-      41 => 'phui-list-view-css',
-      42 => 'font-fontawesome',
-      43 => 'phui-font-icon-base-css',
-      44 => 'sprite-main-header-css',
-      45 => 'phui-box-css',
-      46 => 'phui-object-box-css',
-      47 => 'phui-timeline-view-css',
-      48 => 'sprite-tokens-css',
-      49 => 'tokens-css',
-      50 => 'phui-status-list-view-css',
+      18 => 'sprite-gradient-css',
+      19 => 'sprite-menu-css',
+      20 => 'sprite-apps-css',
+      21 => 'sprite-apps-large-css',
+      22 => 'phabricator-main-menu-view',
+      23 => 'phabricator-notification-css',
+      24 => 'phabricator-notification-menu-css',
+      25 => 'lightbox-attachment-css',
+      26 => 'phui-header-view-css',
+      27 => 'phabricator-filetree-view-css',
+      28 => 'phabricator-nav-view-css',
+      29 => 'phabricator-side-menu-view-css',
+      30 => 'phabricator-crumbs-view-css',
+      31 => 'phui-object-item-list-view-css',
+      32 => 'global-drag-and-drop-css',
+      33 => 'phui-spacing-css',
+      34 => 'phui-form-css',
+      35 => 'phui-icon-view-css',
+      36 => 'phabricator-application-launch-view-css',
+      37 => 'phabricator-action-list-view-css',
+      38 => 'phui-property-list-view-css',
+      39 => 'phui-tag-view-css',
+      40 => 'phui-list-view-css',
+      41 => 'font-fontawesome',
+      42 => 'phui-font-icon-base-css',
+      43 => 'sprite-main-header-css',
+      44 => 'phui-box-css',
+      45 => 'phui-object-box-css',
+      46 => 'phui-timeline-view-css',
+      47 => 'sprite-tokens-css',
+      48 => 'tokens-css',
+      49 => 'phui-status-list-view-css',
     ),
     'core.pkg.js' =>
     array(

resources/celerity/packages.php

@@ -91,7 +91,6 @@
     'phabricator-flag-css',
     'aphront-error-view-css',
 
-    'sprite-remarkup-css',
     'sprite-gradient-css',
     'sprite-menu-css',
     'sprite-apps-css',

resources/sprite/manifest/remarkup.json

@@ -27,7 +27,6 @@
 $generator = new CeleritySpriteGenerator();
 
 $sheets = array(
-  'remarkup' => $generator->buildRemarkupSheet(),
   'menu' => $generator->buildMenuSheet(),
   'apps' => $generator->buildAppsSheet(),
   'minicons' => $generator->buildMiniconsSheet(),

scripts/celerity/generate_sprites.php

@@ -2,50 +2,6 @@
 
 final class CeleritySpriteGenerator {
 
-  public function buildRemarkupSheet() {
-
-    $scales = array(
-      '1x'  => 1,
-      '2x'  => 2,
-    );
-    $sprites = array();
-
-    $template = id(new PhutilSprite())
-      ->setSourceSize(14, 14);
-
-    $remarkup_icons = $this->getDirectoryList('remarkup_1x');
-    foreach ($remarkup_icons as $icon) {
-      $prefix = 'remarkup_';
-
-      // Strip 'text_' from these file names.
-      $class_name = substr($icon, 5);
-
-      if ($class_name == 'fullscreen_off') {
-        $tcss = '.remarkup-control-fullscreen-mode .remarkup-assist-fullscreen';
-      } else {
-        $tcss = '.remarkup-assist-'.$class_name;
-      }
-
-      $sprite = id(clone $template)
-        ->setName('remarkup-assist-'.$icon)
-        ->setTargetCSS($tcss);
-
-      foreach ($scales as $scale_key => $scale) {
-        $path = $this->getPath($prefix.$scale_key.'/'.$icon.'.png');
-        $sprite->setSourceFile($path, $scale);
-      }
-      $sprites[] = $sprite;
-    }
-
-    $sheet = $this->buildSheet('remarkup', true);
-    $sheet->setScales($scales);
-    foreach ($sprites as $sprite) {
-      $sheet->addSprite($sprite);
-    }
-
-    return $sheet;
-  }
-
   public function buildMiniconsSheet() {
     $icons = $this->getDirectoryList('minicons_white_1x');