update from base #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade `should` module
* Remove sl-blip from dependencies (Miroslav Bajtoš) * Upgrade `should` module (Amir Jafarian) * removed console.log (cgole) * seperate env variable for test db (cgole) * Changed username to user (cgole) * Added db username password (cgole) * Add mysql CI host (cgole) * Refer to licenses with a link (Sam Roberts) * Pass options to the execute command. (Diogo Correia) * Use strongloop conventions for licensing (Sam Roberts)
Implementation of ReplaceOrCreate - mysql
Add `connectorCapabilities `
Handle url in config Override other settings if url provided
Use url to override other settings if url provided
Add function connect
Per MySQL docs (http://dev.mysql.com/doc/refman/5.7/en/date-and-time-types.html): "MySQL permits you to store a “zero” value of '0000-00-00' as a “dummy date.” This is in some cases more convenient than using NULL values, and uses less data and index space. To disallow '0000-00-00', enable the NO_ZERO_DATE mode. “Zero” date or time values used through Connector/ODBC are converted automatically to NULL because ODBC cannot handle such values." As we are not using Connector/ODBC we need to handle this ourself.
Add globalization
If no password is given, '+ password' stringifies to 'undefined', which generates a URL that has 'undefined' as the password instead of leaving out the password.
Only run if the environment defines a test database to connect to.
Use should.match() so we can use case-insensitve regexp for properties that change case depending on the server being tested against.
Some of the tests are based on default behaviour of MySQL 5.5 or older which is not the same as 5.7 out of the box.
Update tests to allow concurrency and newer MySQL
Allow the tests to run on ci.strongloop.com using the credentials that are given there, but translate them to the form that is used on cis-jenkins, which is actually the correct format.
Index cardinality is actually a metric that is based on MySQL analyzing the table contents, so its value here has more to do with whether the tests are running against a new table, an old table, or whether it has any data in it. The Sub_part field is similarly unimportant for the purposes of these tests since it refers to indexing internals based on data type and partial indexing. See: https://dev.mysql.com/doc/refman/5.5/en/show-index.html
Update deps to loopback 3.0.0 RC
Add translated files
* TEST_ prefix is not used by CI anymore and there for serve no purpose * Part of overall goal to standardize env var injection to MODULE_VARNAME (ie. MYSQL_HOST for example) convention
* Add connectorCapabilities global object (#201) (Nicholas Duffy) * Remove unused prefix for test env vars (#203) (Simon Ho) * Update translation files - round#2 (#199) (Candy) * Add CI fixes (#197) (Loay) * Add translated files (gunjpan) * Update deps to loopback 3.0.0 RC (Miroslav Bajtoš) * Remove Makefile in favour of NPM test scripts (Simon Ho) * Fixing lint errors (Ron Lloyd) * Autoupdate mysql.columnName bug fix (Ron Lloyd) * Tests for autoupdate mysql.columnName bug fix (Ron Lloyd) * Use juggler@3 for running the tests (Miroslav Bajtoš) * Explictly set forceId:false in test model (Miroslav Bajtoš) * Fix pretest and init test configs (Simon Ho) * Fix to configure model index in keys field (deepakrkris) * Update eslint infrastructure (Loay) * test: use dump of original test DB as seed (Ryan Graham) * test: skip cardinality, update sub_part (Ryan Graham) * test: accept alternate test db credentials (Ryan Graham) * test: use should for easier debugging (Ryan Graham) * test: account for mysql version differences (Ryan Graham) * test: match case with example/table.sql (Ryan Graham) * test: separate assertions from test flow control (Ryan Graham) * test: update tests to use example DB (Ryan Graham) * test: seed test DB with example (Ryan Graham) * test: fix undefined password (Ryan Graham) * Add special handling of zero date/time entries (Carl Fürstenberg) * Add globalization (Candy) * Update URLs in CONTRIBUTING.md (#176) (Ryan Graham)
Update README with correct doc links, etc
Start 3.x + drop support for Node v0.10/v0.12
Fix CI Failures
Replicate .github from loopback repo
Fix mysql column name being ignored on dataType change or new column being added Fix mysql column name ignored if index changed Add column name case on autoupdate test Fix test case scheme error Fix describe test
Fix expected column name when autoupdate
* Update readme w info from docs * Update README.md * Update README.md Fix problems, clarify.
* Update README.md * Update README.md
Per http://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html `BOOL` and `BOOLEAN` is alias for `TINYINT(1)` thus we should make sure discover can handle as such. Introducing three flags: * treatCHAR1AsString default false - treats CHAR(1) as a String instead of a Boolean * treatBIT1AsBit default true - treats BIT(1) as a Boolean instead of a Binary * treatTINYINT1AsTinyInt default true - treats TINYINT(1) as a Boolean instead of a Number The default handling for CHAR(1) is legacy backward compability due to custom to use a CHAR(1) to store 'Y', 'N', '0', '1', etc...
Follow mysql recommendations for handling booleans
* Follow mysql recommendations for handling booleans (Carl Fürstenberg) * Fix readme glitch (#231) (Rand McKinney) * Update readme w info from docs (#229) (Rand McKinney) * Fix expected column name when autoupdate (muhammad hasan) * Update paid support URL (Siddhi Pai) * Fix CI Failures (Loay Gewily) * Drop support for Node v0.10 and v0.12 (Siddhi Pai) * Start the development of the next major version (Siddhi Pai) * Update README with correct doc links, etc (Amir Jafarian)
Update LB-connector version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.