Skip to content

applied legend li span styling to *-legend-icon only (references jtbl…#369

Merged
jtblin merged 1 commit intojtblin:masterfrom
polyglotted:master
Apr 23, 2016
Merged

applied legend li span styling to *-legend-icon only (references jtbl…#369
jtblin merged 1 commit intojtblin:masterfrom
polyglotted:master

Conversation

@davidfhaines
Copy link
Copy Markdown
Contributor

Description of change

Legend icon and text are both spans within a list item. Styling should apply to legend icon spans only. See #366.

Pull Request check-list

  • Run gulp test to ensure there are no linting, or style issues and all tests pass.
  • Squash your commits into a few commits only.
  • Make sure the commit message is short, concise and descriptive of the issues you're fixing.
  • Avoid mixing up multiple issues and/or features, open one pull request for each issue.
  • Have you updated the documentation and / or examples?
  • Have you included a new test?

…in/angular-chart.js#366)

@jtblin jtblin merged commit 10de424 into jtblin:master Apr 23, 2016
@jtblin
Copy link
Copy Markdown
Owner

jtblin commented Apr 23, 2016

Thanks @davidfhaines!

@davidfhaines
Copy link
Copy Markdown
Contributor Author

My pleasure @jtblin. Would it make sense to adjust CONTRIBUTING.md to introduce an alternative workflow using the docker assets provided? I had trouble installing GRAPHICSMAGICK so reverted to docker to test.

@jtblin
Copy link
Copy Markdown
Owner

jtblin commented Apr 23, 2016

Yes you're right, should use docker now for tests actually to ensure reproducibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants