applied legend li span styling to *-legend-icon only (references jtbl…#369
Merged
jtblin merged 1 commit intojtblin:masterfrom Apr 23, 2016
Merged
applied legend li span styling to *-legend-icon only (references jtbl…#369jtblin merged 1 commit intojtblin:masterfrom
jtblin merged 1 commit intojtblin:masterfrom
Conversation
Owner
|
Thanks @davidfhaines! |
Contributor
Author
|
My pleasure @jtblin. Would it make sense to adjust CONTRIBUTING.md to introduce an alternative workflow using the docker assets provided? I had trouble installing GRAPHICSMAGICK so reverted to docker to test. |
Owner
|
Yes you're right, should use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Legend icon and text are both spans within a list item. Styling should apply to legend icon spans only. See #366.
Pull Request check-list
gulp testto ensure there are no linting, or style issues and all tests pass.…in/angular-chart.js#366)