-
-
Notifications
You must be signed in to change notification settings - Fork 38
Regenerated SVG for Card 23 - ES #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gitfichas ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@vale-c thanks for the PR, I believe the card is not using the correct typography or displaying the contents from the card. Can you regenerate the image using the image generation script like this: python3 scripts/generate_images_only.py "023.md" --force |
Of course @jtemporal , I will do that and update the PR! Thanks for the heads-up ✨ |
Hey @jtemporal 👋🏻 ! I have just ran the script like you described but, unfortunately, I noticed that the resulting image has some text being cut-off at the borders for some reason. I tried multiple times but the result is still the same. If you are OK with this I can undo my most recent commit (i.e. the one with broken text) and keep my original attempt with the background color fixed which seemed to be the original problem as can be seen here: Thanks a lot again 🙏🏻 EDIT: I've just undone my most recent commit to fix the broken text. The image now has correct size, visible text, and does not have the wrong #fafafa color but a white background like all the other SVGs. |
b3706d9
to
8875a08
Compare
Closing to focus on a different issue so as not to leave this one pending. Thanks again! 🙏🏻 |
@vale-c I figured out what was causing problems it was some font-sizing in css for the svg (I tested on both MacOS and Linux and it is now working) if you want you can re-work this one and try generating the image with the code from main. |
Amazing, thanks a lot for looking into this @jtemporal ! I will re-open it then and re-run the script 🙌🏻 |
If now doesn't work I can share the image I generated to update this one =) |
8875a08
to
2b70cf9
Compare
Thank you so much @jtemporal ! Seems like the script has worked now 🥳 |
Awesome!! Thanks for the patience with the whole process @vale-c ! Happily merged this one! |
Summary
xmllint --noout
Fix #426
Testing
bundle exec jekyll serve
Screenshot