Skip to content

Conversation

vale-c
Copy link
Contributor

@vale-c vale-c commented Oct 18, 2025

Summary

  • ensure ES card 023 static SVG uses a pure white background so the command text stays readable
  • keep the regenerated mermaid output intact aside from the background color adjustment
  • validated the updated SVG syntax with xmllint --noout

Fix #426

Testing

  • bundle exec jekyll serve

Screenshot

screenshot-2025-10-18_13-24-48

Copy link

netlify bot commented Oct 18, 2025

Deploy Preview for gitfichas ready!

Name Link
🔨 Latest commit 2b70cf9
🔍 Latest deploy log https://app.netlify.com/projects/gitfichas/deploys/68f3f4641c2c32000915c64f
😎 Deploy Preview https://deploy-preview-434--gitfichas.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jtemporal
Copy link
Owner

@vale-c thanks for the PR, I believe the card is not using the correct typography or displaying the contents from the card. Can you regenerate the image using the image generation script like this:

python3 scripts/generate_images_only.py "023.md" --force

@vale-c
Copy link
Contributor Author

vale-c commented Oct 18, 2025

@vale-c thanks for the PR, I believe the card is not using the correct typography or displaying the contents from the card. Can you regenerate the image using the image generation script like this:

python3 scripts/generate_images_only.py "023.md" --force

Of course @jtemporal , I will do that and update the PR! Thanks for the heads-up ✨

@vale-c
Copy link
Contributor Author

vale-c commented Oct 18, 2025

@vale-c thanks for the PR, I believe the card is not using the correct typography or displaying the contents from the card. Can you regenerate the image using the image generation script like this:

python3 scripts/generate_images_only.py "023.md" --force

Hey @jtemporal 👋🏻 !

I have just ran the script like you described but, unfortunately, I noticed that the resulting image has some text being cut-off at the borders for some reason. I tried multiple times but the result is still the same.

If you are OK with this I can undo my most recent commit (i.e. the one with broken text) and keep my original attempt with the background color fixed which seemed to be the original problem as can be seen here:
screenshot-2025-10-18_17-14-18

Thanks a lot again 🙏🏻

EDIT: I've just undone my most recent commit to fix the broken text. The image now has correct size, visible text, and does not have the wrong #fafafa color but a white background like all the other SVGs.

@vale-c vale-c force-pushed the chore/regenerate-es-023-svg branch from b3706d9 to 8875a08 Compare October 18, 2025 15:19
@vale-c
Copy link
Contributor Author

vale-c commented Oct 18, 2025

Closing to focus on a different issue so as not to leave this one pending. Thanks again! 🙏🏻

@vale-c vale-c closed this Oct 18, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in GitFichas Hacktoberfest 2025 Oct 18, 2025
@jtemporal
Copy link
Owner

@vale-c I figured out what was causing problems it was some font-sizing in css for the svg (I tested on both MacOS and Linux and it is now working) if you want you can re-work this one and try generating the image with the code from main.

@vale-c
Copy link
Contributor Author

vale-c commented Oct 18, 2025

@vale-c I figured out what was causing problems it was some font-sizing in css for the svg (I tested on both MacOS and Linux and it is now working) if you want you can re-work this one and try generating the image with the code from main.

Amazing, thanks a lot for looking into this @jtemporal ! I will re-open it then and re-run the script 🙌🏻

@vale-c vale-c reopened this Oct 18, 2025
@jtemporal
Copy link
Owner

If now doesn't work I can share the image I generated to update this one =)

@jtemporal jtemporal moved this from Done to In Progress in GitFichas Hacktoberfest 2025 Oct 18, 2025
@vale-c vale-c force-pushed the chore/regenerate-es-023-svg branch from 8875a08 to 2b70cf9 Compare October 18, 2025 20:11
@vale-c
Copy link
Contributor Author

vale-c commented Oct 18, 2025

If now doesn't work I can share the image I generated to update this one =)

Thank you so much @jtemporal ! Seems like the script has worked now 🥳

@jtemporal jtemporal merged commit e24eb6b into jtemporal:main Oct 18, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in GitFichas Hacktoberfest 2025 Oct 18, 2025
@jtemporal
Copy link
Owner

Awesome!! Thanks for the patience with the whole process @vale-c ! Happily merged this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Regenerate SVG for es card 23

2 participants