Allow more rows to be used in the keypad #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If your keypad matrix has more than 10 rows there will be scanning issues. Raising MAPSIZE to 12 allows for two more rows to be used. Theoretically the maximum number of rows should be 16, accounting for 256 possible key values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your keypad matrix has more than 10 rows there will be scanning issues. Raising MAPSIZE to 12 allows for two more rows to be used. Theoretically the maximum number of rows should be 16, accounting for 256 possible key values, but the practical limit is not known for me.
Notice that with big keyboards is not always possible to arrange the key matrix using more columns than rows, i.e., for a 140 keys keyboard is not optimal to use 14 columns x10 rows but something like 12x12 or 13x11.