Skip to content

Automate EDA with data explorer#42

Merged
lubin-liu merged 9 commits into
jtr13:masterfrom
jingyouu:Automate_EDA_with_DataExplorer
Nov 21, 2020
Merged

Automate EDA with data explorer#42
lubin-liu merged 9 commits into
jtr13:masterfrom
jingyouu:Automate_EDA_with_DataExplorer

Conversation

@jingyouu
Copy link
Copy Markdown
Contributor

No description provided.

@ybliu9 ybliu9 added data analysis chap 6: other topics a catch-all for chapters that don't fit into existing categories labels Nov 18, 2020
Comment thread Automate_EDA_with_DataExplorer.Rmd Outdated
@@ -0,0 +1,174 @@
# Automate EDA with DataExplorer
Copy link
Copy Markdown
Collaborator

@lubin-liu lubin-liu Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the .rmd file name and the folder file name in the resources should be all lower case. Also make sure that the .Rmd filename still matches the root directory name of the branch:

See 17.2.2 for filename requirements:

https://jtr13.github.io/cc20/tutorial-for-pull-request-mergers.html

Comment thread Automate_EDA_with_DataExplorer.Rmd Outdated
#create_report(final_sleep)
````

![Data report sample](resources/Automate_EDA_with_DataExplorer/unknown.png)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update folder file name to all lower case to match .rmd. Also, the filename in the folder is 'Unknown.png', not 'unknown.png', would update one of these to make the names consistent.

Copy link
Copy Markdown
Collaborator

@lubin-liu lubin-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes indicated by the comments for line 1 and 154.

@lubin-liu lubin-liu merged commit a9a8755 into jtr13:master Nov 21, 2020
@lubin-liu
Copy link
Copy Markdown
Collaborator

Your project has been merged, thanks for your contribution! 👍 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chap 6: other topics a catch-all for chapters that don't fit into existing categories data analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants