feat(skills): make manager workflow skills binding and trigger-explicit#7
Merged
Conversation
Rewrite iterative-review, sow-workflow, and delegation with unconditional triggers, refusal directives, and explicit priority over memory. Managers were skipping reviewers because the skills were framed advisorily; binding prose fixes this without any Rust changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iterative-review,sow-workflow, anddelegationskill prompts with unconditional triggers, refusal directives, and explicit "priority over memory" sections.Why prose-only
Skills are loaded via
include_dir!fromsrc-tauri/embedded/skills/and merged into each agent's system prompt byagent_instructions_with_skills(). The failure mode in the field was content-level, not architectural: skills said "Use this workflow when the user asks…" — an off-ramp the model takes. The rewrites remove the off-ramp, name the trigger actions (git push,gh pr create,workspace_finishTaskwith shipped code, deploy/release commands), and explicitly subordinate memory updates to the workflow loop.Files changed
src-tauri/embedded/skills/iterative-review/SKILL.md— binding, action-triggered, with refusal and BLOCKED protocolssrc-tauri/embedded/skills/sow-workflow/SKILL.md— binding, runs on every file-modifying run, composes with iterative-review for completion gatesrc-tauri/embedded/skills/delegation/SKILL.md— advisory, drops "use when" preamble, prescribes parallel dispatchTest plan
cargo tauri devorcargo tauri build) so the new embedded skill text takes effect.code-reviewersibling, attachiterative-review. Run autonomously and confirmworkspace_assignTaskis dispatched to every reviewer before anygit push/gh pr create.production_quality, then ships.sow-workflowattached, confirm.clai/sow/index.mdis read/created at run start and the SOW'sstate.mdis updated at end of run.iterative-reviewskill attached, confirm the manager ships without the loop (so removing the skill is still the off-switch).