Skip to content

feat(skills): make manager workflow skills binding and trigger-explicit#7

Merged
juacker merged 1 commit into
mainfrom
qa/binding-workflow-skills
May 21, 2026
Merged

feat(skills): make manager workflow skills binding and trigger-explicit#7
juacker merged 1 commit into
mainfrom
qa/binding-workflow-skills

Conversation

@juacker
Copy link
Copy Markdown
Owner

@juacker juacker commented May 21, 2026

Summary

  • Rewrites the iterative-review, sow-workflow, and delegation skill prompts with unconditional triggers, refusal directives, and explicit "priority over memory" sections.
  • Manager agents were skipping reviewer dispatch because the skills were framed advisorily ("use when…"); binding prose fixes this without touching any Rust code or the prompt assembly pipeline.
  • Sets up the prompt content that future predefined workspace templates can stamp onto manager agents.

Why prose-only

Skills are loaded via include_dir! from src-tauri/embedded/skills/ and merged into each agent's system prompt by agent_instructions_with_skills(). The failure mode in the field was content-level, not architectural: skills said "Use this workflow when the user asks…" — an off-ramp the model takes. The rewrites remove the off-ramp, name the trigger actions (git push, gh pr create, workspace_finishTask with shipped code, deploy/release commands), and explicitly subordinate memory updates to the workflow loop.

Files changed

  • src-tauri/embedded/skills/iterative-review/SKILL.md — binding, action-triggered, with refusal and BLOCKED protocols
  • src-tauri/embedded/skills/sow-workflow/SKILL.md — binding, runs on every file-modifying run, composes with iterative-review for completion gate
  • src-tauri/embedded/skills/delegation/SKILL.md — advisory, drops "use when" preamble, prescribes parallel dispatch

Test plan

  • Rebuild the app (cargo tauri dev or cargo tauri build) so the new embedded skill text takes effect.
  • On a manager agent with at least one code-reviewer sibling, attach iterative-review. Run autonomously and confirm workspace_assignTask is dispatched to every reviewer before any git push / gh pr create.
  • Confirm the manager loops (re-dispatches the same reviewers with the same full scope) until every verdict is production_quality, then ships.
  • Ask the manager in chat to "just push without review this once" — verify it refuses and quotes the skill.
  • On a manager with sow-workflow attached, confirm .clai/sow/index.md is read/created at run start and the SOW's state.md is updated at end of run.
  • Negative case: with no iterative-review skill attached, confirm the manager ships without the loop (so removing the skill is still the off-switch).

Rewrite iterative-review, sow-workflow, and delegation with
unconditional triggers, refusal directives, and explicit priority
over memory. Managers were skipping reviewers because the skills
were framed advisorily; binding prose fixes this without any
Rust changes.
@juacker juacker merged commit e4874f4 into main May 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant