Skip to content

[ENH]: Adopt structlog for logging#231

Merged
synchon merged 13 commits intomainfrom
update/structlog-for-loggin
Oct 23, 2025
Merged

[ENH]: Adopt structlog for logging#231
synchon merged 13 commits intomainfrom
update/structlog-for-loggin

Conversation

@synchon
Copy link
Copy Markdown
Member

@synchon synchon commented Apr 11, 2024

junifer's auditing via logs is nice and is an important feature for understanding how the pipeline runs for an experiment. structlog (https://github.com/hynek/structlog) has good reputation and can enable junifer to step up its logging without much effort.

@synchon synchon added the enhancement New feature or request label May 17, 2023
@synchon synchon added the maintenance Issues or pull requests related to maintenance label Jul 7, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.65%. Comparing base (ef3c341) to head (371305f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   91.65%   91.65%   -0.01%     
==========================================
  Files         146      146              
  Lines        5990     5989       -1     
  Branches      954      954              
==========================================
- Hits         5490     5489       -1     
  Misses        324      324              
  Partials      176      176              
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/utils/logging.py 98.70% <ø> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@synchon synchon force-pushed the update/structlog-for-loggin branch from 82b43ae to 3f32da4 Compare May 6, 2024 10:29
@synchon synchon force-pushed the update/structlog-for-loggin branch from 3f32da4 to 3ed7df0 Compare May 14, 2024 11:51
@synchon synchon force-pushed the update/structlog-for-loggin branch from 3ed7df0 to 73ea9c8 Compare June 3, 2024 14:58
@synchon synchon force-pushed the update/structlog-for-loggin branch from 73ea9c8 to 2bf023b Compare June 21, 2024 10:20
@synchon synchon force-pushed the update/structlog-for-loggin branch from 2bf023b to 2435fab Compare August 8, 2024 06:17
@fraimondo fraimondo added this to the 0.0.6 (alpha 5) milestone Sep 24, 2024
@synchon synchon force-pushed the update/structlog-for-loggin branch 2 times, most recently from 00876f3 to aed4c7b Compare February 17, 2025 11:56
@synchon synchon marked this pull request as draft March 14, 2025 15:32
@synchon synchon force-pushed the update/structlog-for-loggin branch from aed4c7b to 6d3d540 Compare August 5, 2025 12:12
@synchon synchon force-pushed the update/structlog-for-loggin branch from 6d3d540 to b02f1c0 Compare September 9, 2025 12:07
@github-actions github-actions bot added the Stale label Oct 10, 2025
@synchon synchon removed the Stale label Oct 10, 2025
@synchon synchon force-pushed the update/structlog-for-loggin branch from b02f1c0 to 371305f Compare October 23, 2025 09:56
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 23, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-23 18:24 UTC

@synchon
Copy link
Copy Markdown
Member Author

synchon commented Oct 23, 2025

CI passes on juseless.

@synchon synchon marked this pull request as ready for review October 23, 2025 15:44
@synchon synchon requested a review from fraimondo October 23, 2025 15:44
@synchon synchon merged commit 0f459e2 into main Oct 23, 2025
4 of 12 checks passed
@synchon synchon deleted the update/structlog-for-loggin branch October 23, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request maintenance Issues or pull requests related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants