Skip to content

Conversation

@LeSasse
Copy link
Collaborator

@LeSasse LeSasse commented Oct 1, 2024

@codecov
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.31%. Comparing base (ab4f391) to head (8087653).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #371   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files          93       93           
  Lines        5067     5067           
  Branches     1031     1031           
=======================================
  Hits         4475     4475           
  Misses        426      426           
  Partials      166      166           
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/datagrabber/aomic/piop2.py 87.17% <ø> (ø)

- Remove extra dimension from masks warped via ANTs by `Synchon Mandal`_
(:gh:`340`)

- Add 'emomatching' task to :class:`DataladAOMICPIOP2` by `Leonard Sasse`_ (:gh:`370`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should now be in the docs/changes/newsfragments directory, in a file named 370.bugfix that has the following content:

Add ``'emomatching'`` task to :class:`DataladAOMICPIOP2` by `Leonard Sasse`_

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see

@synchon synchon changed the title add emomatching task to piop2 datagrabber Add emomatching task to AOMIC PIOP2 datagrabber Oct 7, 2024
@synchon synchon added bug Something isn't working dataset Issues or pull requests related to datagrabbers or datasets labels Oct 7, 2024
@synchon synchon added this to the 0.0.6 (alpha 5) milestone Oct 7, 2024
@github-actions
Copy link

github-actions bot commented Oct 7, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-07 10:37 UTC

@synchon synchon merged commit 4cbe83d into main Oct 7, 2024
@synchon synchon deleted the fix/piop2_tasks branch October 7, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dataset Issues or pull requests related to datagrabbers or datasets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: AOMIC PIOP2 missing tasks

4 participants