-
Notifications
You must be signed in to change notification settings - Fork 13
[ENH]: Introduce data registries #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
- Coverage 87.93% 87.91% -0.02%
==========================================
Files 118 118
Lines 5162 5154 -8
Branches 841 841
==========================================
- Hits 4539 4531 -8
Misses 454 454
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
|
There's an issue with the 3.12 tests, regarding FSL. Once this is fixed and CI is green, can be merged. |
It's something specific to FSL |
@fraimondo Got the solution in #383 but it changes the CI testing env so we can merge this and then get that in and continue, what do you think? |
…acing with coordinates data
…facing with parcellation data
a23663d to
c0e5a42
Compare
As long as the end product is green, I'm ok with either way. |
This PR introduces new singleton classes:
ParcellationRegistry,CoordinatesRegistryandMaskRegistryfor centralizing data registries used in the codebase, easing encapsulation. It also replaces helper data functions:{get,load,list,register}_{parcellation,coordinates,mask}with new "dynamically dispatched" functions like:{get,load,list,register,deregister}_datawhich act as helpers for the data registries.