Skip to content

Conversation

@synchon
Copy link
Member

@synchon synchon commented Oct 29, 2024

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR introduces new singleton classes: ParcellationRegistry, CoordinatesRegistry and MaskRegistry for centralizing data registries used in the codebase, easing encapsulation. It also replaces helper data functions: {get,load,list,register}_{parcellation,coordinates,mask} with new "dynamically dispatched" functions like: {get,load,list,register,deregister}_data which act as helpers for the data registries.

@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (f61d1da) to head (c0e5a42).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   87.93%   87.91%   -0.02%     
==========================================
  Files         118      118              
  Lines        5162     5154       -8     
  Branches      841      841              
==========================================
- Hits         4539     4531       -8     
  Misses        454      454              
  Partials      169      169              
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/data/utils.py 100.00% <ø> (ø)
junifer/markers/complexity/hurst_exponent.py 72.41% <ø> (ø)
...nifer/markers/complexity/multiscale_entropy_auc.py 87.50% <ø> (ø)
junifer/markers/complexity/perm_entropy.py 86.20% <ø> (ø)
junifer/markers/complexity/range_entropy.py 87.09% <ø> (ø)
junifer/markers/complexity/range_entropy_auc.py 92.10% <ø> (ø)
junifer/markers/complexity/sample_entropy.py 87.50% <ø> (ø)
...unifer/markers/complexity/weighted_perm_entropy.py 86.20% <ø> (ø)
junifer/markers/ets_rss.py 100.00% <ø> (ø)
junifer/markers/falff/falff_parcels.py 100.00% <ø> (ø)
... and 13 more

... and 1 file with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Oct 29, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-31 12:42 UTC

@synchon synchon requested a review from fraimondo October 29, 2024 12:49
@fraimondo
Copy link
Contributor

There's an issue with the 3.12 tests, regarding FSL. Once this is fixed and CI is green, can be merged.

@synchon
Copy link
Member Author

synchon commented Oct 30, 2024

There's an issue with the 3.12 tests, regarding FSL. Once this is fixed and CI is green, can be merged.

It's something specific to FSL susan and not any other FSL tool we use, tried fixing in the CI image but doesn't seem to work as it somehow needs to be hardcoded in .profile I guess. As the problem is unrelated to this PR, I can tackle it in another one; since I need this PR for the upcoming ones.

@synchon synchon added the enhancement New feature or request label Oct 30, 2024
@synchon synchon added this to the 0.0.6 (alpha 5) milestone Oct 30, 2024
@synchon
Copy link
Member Author

synchon commented Oct 31, 2024

There's an issue with the 3.12 tests, regarding FSL. Once this is fixed and CI is green, can be merged.

It's something specific to FSL susan and not any other FSL tool we use, tried fixing in the CI image but doesn't seem to work as it somehow needs to be hardcoded in .profile I guess. As the problem is unrelated to this PR, I can tackle it in another one; since I need this PR for the upcoming ones.

@fraimondo Got the solution in #383 but it changes the CI testing env so we can merge this and then get that in and continue, what do you think?

@synchon synchon force-pushed the feat/data-registries branch from a23663d to c0e5a42 Compare October 31, 2024 12:04
@fraimondo
Copy link
Contributor

@fraimondo Got the solution in #383 but it changes the CI testing env so we can merge this and then get that in and continue, what do you think?

As long as the end product is green, I'm ok with either way.

@synchon synchon merged commit 44befaf into main Oct 31, 2024
@synchon synchon deleted the feat/data-registries branch October 31, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants