Skip to content

Conversation

@synchon
Copy link
Member

@synchon synchon commented Dec 3, 2024

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR refactors the space transformation logic of parcellations to optimize warping at higher resolutions and joining in correct space. Follows very similar thought-process as in #395.

@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 0.01%. Comparing base (ed5db99) to head (b86d632).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
junifer/data/parcellations/_parcellations.py 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #411      +/-   ##
========================================
- Coverage   0.01%   0.01%   -0.01%     
========================================
  Files        133     133              
  Lines       5714    5719       +5     
========================================
  Hits           1       1              
- Misses      5713    5718       +5     
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/data/parcellations/_parcellations.py 0.00% <0.00%> (ø)

@synchon synchon added the parcellation Issues or pull requests related to parcellations (deterministic atlases) label Dec 3, 2024
@synchon synchon added this to the 0.0.6 (alpha 5) milestone Dec 3, 2024
@github-actions
Copy link

github-actions bot commented Dec 3, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://juaml.github.io/junifer/pr-preview/pr-411/
on branch gh-pages at 2024-12-06 14:01 UTC

@synchon synchon force-pushed the refactor/parcellation-logic branch 2 times, most recently from 45e8883 to d64bfe7 Compare December 6, 2024 11:15
@synchon synchon force-pushed the refactor/parcellation-logic branch from d64bfe7 to 70e73b3 Compare December 6, 2024 11:40
@synchon synchon merged commit 12ecdb2 into main Dec 6, 2024
17 of 21 checks passed
@synchon synchon deleted the refactor/parcellation-logic branch December 6, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parcellation Issues or pull requests related to parcellations (deterministic atlases)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants