-
Notifications
You must be signed in to change notification settings - Fork 13
FIx CI coverage #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIx CI coverage #424
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
+ Coverage 0.01% 85.55% +85.53%
==========================================
Files 133 133
Lines 5795 5795
Branches 0 982 +982
==========================================
+ Hits 1 4958 +4957
+ Misses 5794 636 -5158
- Partials 0 201 +201
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Just a fix for the coverage issue. |
| pytest | ||
| pytest-cov | ||
| commands = | ||
| pytest --cov={envsitepackagesdir}/junifer --cov-report=xml --cov-report=term |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We either test and evaluate coverage on {envsitepackagesdir} or on the checked out code.
My take is that this way we are testing what we ship in the installable package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it stopped reporting coverage out of the blue so as long as we are back, we are good.
|
synchon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a fragment file and good to go.
| pytest | ||
| pytest-cov | ||
| commands = | ||
| pytest --cov={envsitepackagesdir}/junifer --cov-report=xml --cov-report=term |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it stopped reporting coverage out of the blue so as long as we are back, we are good.
Uh oh!
There was an error while loading. Please reload this page.