Skip to content

Conversation

@fraimondo
Copy link
Contributor

@fraimondo fraimondo commented Jan 27, 2025

  • fix #(issue number)
  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.55%. Comparing base (5135251) to head (2a542b2).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main     #424       +/-   ##
==========================================
+ Coverage   0.01%   85.55%   +85.53%     
==========================================
  Files        133      133               
  Lines       5795     5795               
  Branches       0      982      +982     
==========================================
+ Hits           1     4958     +4957     
+ Misses      5794      636     -5158     
- Partials       0      201      +201     
Flag Coverage Δ
junifer 85.55% <ø> (+85.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 132 files with indirect coverage changes

@fraimondo
Copy link
Contributor Author

Just a fix for the coverage issue.

@fraimondo fraimondo requested a review from synchon January 27, 2025 08:53
pytest
pytest-cov
commands =
pytest --cov={envsitepackagesdir}/junifer --cov-report=xml --cov-report=term
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We either test and evaluate coverage on {envsitepackagesdir} or on the checked out code.

My take is that this way we are testing what we ship in the installable package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it stopped reporting coverage out of the blue so as long as we are back, we are good.

@github-actions
Copy link

github-actions bot commented Jan 27, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-01-28 08:22 UTC

Copy link
Member

@synchon synchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a fragment file and good to go.

pytest
pytest-cov
commands =
pytest --cov={envsitepackagesdir}/junifer --cov-report=xml --cov-report=term
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it stopped reporting coverage out of the blue so as long as we are back, we are good.

@fraimondo fraimondo merged commit edaa261 into main Jan 28, 2025
10 of 13 checks passed
@fraimondo fraimondo deleted the fix_coverage branch January 28, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants