[ENH]: Implement a NaN policy for onthefly.read_transform#429
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
==========================================
+ Coverage 91.26% 91.30% +0.03%
==========================================
Files 135 135
Lines 5566 5588 +22
Branches 905 910 +5
==========================================
+ Hits 5080 5102 +22
Misses 313 313
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
synchon
force-pushed
the
enh/read_transform_nan
branch
from
ea37687 to
310ea9d
Compare
synchon
force-pushed
the
enh/read_transform_nan
branch
from
310ea9d to
a39f64c
Compare
synchon
changed the title
onthefly.read_transform
synchon
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a policy to handle NaN values before calling the respective transformation function in
read_transform.Current options are:
bypass: do nothing, pass NaNs.drop_element: skip elements with at least one NaN valuedrop_rows: skip rows with at least one NaN valuedrop_symmetric: skip rows and columns symmetrically, keeping the matrix squared.