Skip to content

[ENH]: Add TemporalFilter#432

Merged
synchon merged 7 commits intomainfrom
enh/temporal_filter
Jul 21, 2025
Merged

[ENH]: Add TemporalFilter#432
synchon merged 7 commits intomainfrom
enh/temporal_filter

Conversation

@fraimondo
Copy link
Copy Markdown
Contributor

@fraimondo fraimondo commented Feb 26, 2025

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR adds TemporalFilter to filter / clean BOLD data via nilean.

@fraimondo fraimondo changed the base branch from enh/read_transform_nan to main February 26, 2025 21:37
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (e153dcf) to head (311602d).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   91.17%   91.26%   +0.09%     
==========================================
  Files         134      135       +1     
  Lines        5507     5566      +59     
  Branches      903      905       +2     
==========================================
+ Hits         5021     5080      +59     
  Misses        313      313              
  Partials      173      173              
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 91.26% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/pipeline/pipeline_component_registry.py 94.64% <ø> (ø)
junifer/preprocess/_temporal_filter.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 26, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-07-21 15:06 UTC

@synchon synchon force-pushed the enh/temporal_filter branch from 9d898da to f886e9c Compare July 21, 2025 10:40
@synchon synchon force-pushed the enh/temporal_filter branch from f886e9c to 218b4e9 Compare July 21, 2025 11:52
@synchon synchon changed the title Add TemporalFilter [ENH]: Add TemporalFilter Jul 21, 2025
@synchon synchon added the preprocess Issues or pull requests related to preprocessors label Jul 21, 2025
@synchon synchon added this to the 0.0.7 (alpha 6) milestone Jul 21, 2025
@synchon synchon marked this pull request as ready for review July 21, 2025 12:02
Copy link
Copy Markdown
Contributor Author

@fraimondo fraimondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't approve the PR cause I'm the author. Feel free to go ahead. Just that typo I mentioned before. Rest is OK.

Comment thread junifer/preprocess/_temporal_filter.py Outdated
@synchon synchon self-requested a review July 21, 2025 14:28
@synchon synchon merged commit 67e4f45 into main Jul 21, 2025
21 checks passed
@synchon synchon deleted the enh/temporal_filter branch July 21, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preprocess Issues or pull requests related to preprocessors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants