Skip to content

[MAINT]: Repository maintenance#441

Merged
synchon merged 24 commits intomainfrom
chore/ruff-format
Apr 10, 2025
Merged

[MAINT]: Repository maintenance#441
synchon merged 24 commits intomainfrom
chore/ruff-format

Conversation

@synchon
Copy link
Copy Markdown
Member

@synchon synchon commented Mar 24, 2025

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR does general repository maintenance by updating .pre-commit-config.yaml, replacing black with ruff-format and updating tool configs.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.00%. Comparing base (4e30385) to head (6764fda).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
junifer/utils/logging.py 83.33% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (91.66%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
+ Coverage   85.77%   91.00%   +5.22%     
==========================================
  Files         133      133              
  Lines        5675     5359     -316     
  Branches      962      893      -69     
==========================================
+ Hits         4868     4877       +9     
+ Misses        618      309     -309     
+ Partials      189      173      -16     
Flag Coverage Δ
junifer 91.00% <91.66%> (+5.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/api/decorators.py 100.00% <ø> (ø)
junifer/api/functions.py 91.36% <ø> (ø)
...er/api/queue_context/gnu_parallel_local_adapter.py 92.92% <ø> (ø)
junifer/api/queue_context/htcondor_adapter.py 96.00% <100.00%> (ø)
junifer/data/_dispatch.py 95.34% <ø> (+57.84%) ⬆️
...nifer/data/coordinates/_ants_coordinates_warper.py 100.00% <ø> (+61.90%) ⬆️
junifer/data/coordinates/_coordinates.py 100.00% <ø> (+20.28%) ⬆️
...unifer/data/coordinates/_fsl_coordinates_warper.py 100.00% <ø> (+50.00%) ⬆️
junifer/data/masks/_ants_mask_warper.py 76.92% <ø> (+49.42%) ⬆️
junifer/data/masks/_fsl_mask_warper.py 75.00% <ø> (+27.38%) ⬆️
... and 32 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://juaml.github.io/junifer/pr-preview/pr-441/

Built to branch gh-pages at 2025-04-03 16:51 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@synchon synchon added the maintenance Issues or pull requests related to maintenance label Mar 24, 2025
@synchon synchon added this to the 0.0.6 (alpha 5) milestone Mar 24, 2025
@synchon synchon force-pushed the chore/ruff-format branch from 6197ab4 to 94b5c0e Compare March 25, 2025 09:49
@synchon synchon requested a review from fraimondo March 26, 2025 10:32
Copy link
Copy Markdown
Contributor

@fraimondo fraimondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this PR needs to be rebased or merged on top of another? Seems that its adding covereage and adding the coordinates registry.

@synchon
Copy link
Copy Markdown
Member Author

synchon commented Mar 28, 2025

This PR is already rebased on main and it's removing the leftover files from coordinates and masks.

@synchon synchon requested review from fraimondo and removed request for fraimondo March 28, 2025 09:35
@synchon synchon force-pushed the chore/ruff-format branch from 19c84f3 to e93dac7 Compare April 1, 2025 12:05
@synchon synchon requested a review from fraimondo April 7, 2025 09:04
@synchon
Copy link
Copy Markdown
Member Author

synchon commented Apr 7, 2025

@fraimondo should be good for review now, the patch coverage is red but it's not a problem.

@synchon
Copy link
Copy Markdown
Member Author

synchon commented Apr 10, 2025

@fraimondo Can we get this in or do you have some review comments?

@synchon synchon merged commit 2bd28e2 into main Apr 10, 2025
20 of 21 checks passed
@synchon synchon deleted the chore/ruff-format branch April 10, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Issues or pull requests related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants