Skip to content

[BUG]: Add timeseries_2d as valid input type for HDF5FeatureStorage#444

Merged
synchon merged 3 commits intomainfrom
patch/timeseries_2d
Apr 25, 2025
Merged

[BUG]: Add timeseries_2d as valid input type for HDF5FeatureStorage#444
synchon merged 3 commits intomainfrom
patch/timeseries_2d

Conversation

@fraimondo
Copy link
Copy Markdown
Contributor

@fraimondo fraimondo commented Apr 25, 2025

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

@synchon synchon force-pushed the patch/timeseries_2d branch from 99a39f6 to b9013e7 Compare April 25, 2025 09:43
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (2bd28e2) to head (b9013e7).

❌ Your project check has failed because the head coverage (86.12%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   86.13%   86.13%   -0.01%     
==========================================
  Files         133      133              
  Lines        5619     5617       -2     
  Branches      950      950              
==========================================
- Hits         4840     4838       -2     
  Misses        600      600              
  Partials      179      179              
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/storage/hdf5.py 93.99% <ø> (-0.05%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@synchon synchon changed the title Fix timeseries_2d storage issue [BUG]: Add timeseries_2d as valid input type for HDF5FeatureStorage Apr 25, 2025
@synchon synchon added the bug Something isn't working label Apr 25, 2025
@synchon synchon added this to the 0.0.7 (alpha 6) milestone Apr 25, 2025
@synchon synchon marked this pull request as ready for review April 25, 2025 12:54
@synchon synchon merged commit 791a334 into main Apr 25, 2025
6 of 8 checks passed
@synchon synchon deleted the patch/timeseries_2d branch April 25, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants