Skip to content

Fix check for FSL #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
synchon merged 2 commits into from
Sep 16, 2025
Merged

Fix check for FSL #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1151cd
Fix check for FSL
fraimondo Jul 27, 2025
fbf867a
chore: add changelog 454.bugfix
synchon Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changes/newsfragments/454.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix FSL presence checking status code by `Fede Raimondo`_
4 changes: 3 additions & 1 deletion junifer/pipeline/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,9 @@ def _check_fsl(commands: Optional[list[str]] = None) -> bool:
shell=True, # is unsafe but kept for resolution via PATH
check=False,
)
fsl_found = completed_process.returncode == 1
fsl_found = (
completed_process.returncode == 1 or completed_process.returncode == 0
)

# Check for specific commands
if fsl_found and commands is not None:
Expand Down