Skip to content

[ENH]: Introduce MapsRegistry#458

Merged
synchon merged 20 commits intomainfrom
feat/maps-registry
Sep 8, 2025
Merged

[ENH]: Introduce MapsRegistry#458
synchon merged 20 commits intomainfrom
feat/maps-registry

Conversation

@synchon
Copy link
Copy Markdown
Member

@synchon synchon commented Aug 11, 2025

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR introduces MapsRegistry for centralized management of maps (probabilistic atlas / parcellations).

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 99.18699% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.45%. Comparing base (87e0d07) to head (2849dc7).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
junifer/data/maps/_maps.py 98.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   91.29%   91.45%   +0.16%     
==========================================
  Files         136      140       +4     
  Lines        5764     5887     +123     
  Branches      941      956      +15     
==========================================
+ Hits         5262     5384     +122     
  Misses        325      325              
- Partials      177      178       +1     
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 91.45% <99.18%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/data/_dispatch.py 93.58% <100.00%> (+0.08%) ⬆️
junifer/data/maps/__init__.py 100.00% <100.00%> (ø)
junifer/data/maps/_ants_maps_warper.py 100.00% <100.00%> (ø)
junifer/data/maps/_fsl_maps_warper.py 100.00% <100.00%> (ø)
junifer/data/masks/_masks.py 69.85% <ø> (ø)
junifer/data/parcellations/_parcellations.py 93.00% <ø> (ø)
junifer/data/maps/_maps.py 98.90% <98.90%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 11, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-09-08 11:24 UTC

@synchon synchon self-assigned this Aug 11, 2025
@synchon synchon added enhancement New feature or request maps Issues or pull requests related to maps (probabilistic atlases) labels Aug 11, 2025
@synchon synchon added this to the 0.0.7 (alpha 6) milestone Aug 11, 2025
@synchon synchon requested a review from fraimondo August 12, 2025 14:23
@fraimondo
Copy link
Copy Markdown
Contributor

Can we add some tests for maps warping? We have 0 coverage on the warpers.

@synchon
Copy link
Copy Markdown
Member Author

synchon commented Aug 13, 2025

Can we add some tests for maps warping? We have 0 coverage on the warpers.

We have similar coverage reporting structure as the parcellations. There's a test for template space warping via ANTs and the native one takes way too much time (hence we didn't have it for parcellation as well). For the FSL one, it only does native space warping, so we don't have a test for that as well.

@synchon synchon force-pushed the feat/maps-registry branch from dd50515 to 987df02 Compare August 19, 2025 09:08
Comment thread docs/builtin.rst Outdated
@synchon synchon requested a review from fraimondo September 8, 2025 09:02
@synchon synchon merged commit 42a09b3 into main Sep 8, 2025
22 checks passed
@synchon synchon deleted the feat/maps-registry branch September 8, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request maps Issues or pull requests related to maps (probabilistic atlases)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants